Files.app: Introduce TestEntryInfo class to JavaScript code.

Files.app: Introduce TestEntryInfo class to JavaScript code.

Currently the test entry data of 'newly added file.ogg' is doubled for creating
and verifiying the entry.  This CL introduces TestEntryInfo class to JavaScript
code and use it for both creating and verifiying the entyr.

BUG=279774
TEST=file_manager_browsertests
R=hashimoto@chromium.org, yoshiki@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222218

[hirono, 2013-09-10 02:31:29]

Could you take a look the CL?
Thank you very much!

[yoshiki, 2013-09-10 04:38:55]

*.js lgtm with nits.

https://codereview.chromium.org/24026003/diff/5001/chrome/test/data/extension...
File chrome/test/data/extensions/api_test/file_manager_browsertest/test_cases.js
(right):

https://codereview.chromium.org/24026003/diff/5001/chrome/test/data/extension...
chrome/test/data/extensions/api_test/file_manager_browsertest/test_cases.js:9:
var EntryType = {
Object.freeze?

https://codereview.chromium.org/24026003/diff/5001/chrome/test/data/extension...
chrome/test/data/extensions/api_test/file_manager_browsertest/test_cases.js:18:
var SharedOption = {
ditto

https://codereview.chromium.org/24026003/diff/5001/chrome/test/data/extension...
chrome/test/data/extensions/api_test/file_manager_browsertest/test_cases.js:54:
};
Object.seal(this)?

[hirono, 2013-09-10 04:56:02]

Thanks!

https://codereview.chromium.org/24026003/diff/5001/chrome/test/data/extension...
File chrome/test/data/extensions/api_test/file_manager_browsertest/test_cases.js
(right):

https://codereview.chromium.org/24026003/diff/5001/chrome/test/data/extension...
chrome/test/data/extensions/api_test/file_manager_browsertest/test_cases.js:9:
var EntryType = {
On 2013/09/10 04:38:55, yoshiki wrote:
> Object.freeze?

Done.

https://codereview.chromium.org/24026003/diff/5001/chrome/test/data/extension...
chrome/test/data/extensions/api_test/file_manager_browsertest/test_cases.js:18:
var SharedOption = {
On 2013/09/10 04:38:55, yoshiki wrote:
> ditto

Done.

https://codereview.chromium.org/24026003/diff/5001/chrome/test/data/extension...
chrome/test/data/extensions/api_test/file_manager_browsertest/test_cases.js:54:
};
On 2013/09/10 04:38:55, yoshiki wrote:
> Object.seal(this)?

This object is immutable, so we can freeze this.

[commit-bot: I haz the power, 2013-09-10 04:56:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hirono@chromium.org/24026003/15001

[hashimoto, 2013-09-10 05:13:34]

lgtm

[commit-bot: I haz the power, 2013-09-10 05:14:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hirono@chromium.org/24026003/15001

[commit-bot: I haz the power, 2013-09-10 06:53:02]

Retried try job too often on mac_rel for step(s) telemetry_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2013-09-10 06:56:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hirono@chromium.org/24026003/15001

[hirono, 2013-09-10 08:45:52]

Committed patchset #3 manually as r222218 (presubmit successful).