Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2402593003: Use FileDescriptorWatcher in LocalInputMonitorX11. (Closed)

Created:
4 years, 2 months ago by fdoray
Modified:
4 years, 2 months ago
Reviewers:
joedow
CC:
chromium-reviews, chromoting-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use FileDescriptorWatcher in LocalInputMonitorX11. This allows LocalInputMonitorX11 to be used from any thread that instantiates a FileDescriptorWatcher (not just threads that run a MessageLoopForIO). This will facilitate the migration of BrowserThreads to base/task_scheduler. BUG=645114 Committed: https://crrev.com/9f0e84139b0c8c3e40798e135f37bde5b0e3c7ad Cr-Commit-Position: refs/heads/master@{#424469}

Patch Set 1 #

Patch Set 2 : fix build error #

Total comments: 2

Patch Set 3 : CR joedow #11" #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -29 lines) Patch
M remoting/host/local_input_monitor_x11.cc View 1 2 8 chunks +13 lines, -29 lines 0 comments Download

Messages

Total messages: 18 (12 generated)
fdoray
PTAL
4 years, 2 months ago (2016-10-11 12:41:04 UTC) #10
joedow
lgtm https://codereview.chromium.org/2402593003/diff/20001/remoting/host/local_input_monitor_x11.cc File remoting/host/local_input_monitor_x11.cc (right): https://codereview.chromium.org/2402593003/diff/20001/remoting/host/local_input_monitor_x11.cc#newcode22 remoting/host/local_input_monitor_x11.cc:22: #include "base/message_loop/message_pump_libevent.h" message_pump_libevent.h can be removed now
4 years, 2 months ago (2016-10-11 16:56:12 UTC) #11
fdoray
https://codereview.chromium.org/2402593003/diff/20001/remoting/host/local_input_monitor_x11.cc File remoting/host/local_input_monitor_x11.cc (right): https://codereview.chromium.org/2402593003/diff/20001/remoting/host/local_input_monitor_x11.cc#newcode22 remoting/host/local_input_monitor_x11.cc:22: #include "base/message_loop/message_pump_libevent.h" On 2016/10/11 16:56:12, joedow wrote: > message_pump_libevent.h ...
4 years, 2 months ago (2016-10-11 17:07:31 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2402593003/40001
4 years, 2 months ago (2016-10-11 17:08:06 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-10-11 17:19:34 UTC) #16
commit-bot: I haz the power
4 years, 2 months ago (2016-10-11 17:22:29 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/9f0e84139b0c8c3e40798e135f37bde5b0e3c7ad
Cr-Commit-Position: refs/heads/master@{#424469}

Powered by Google App Engine
This is Rietveld 408576698