Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(969)

Issue 2402583004: [inspector] fixed one more size_t -> int conversion (Closed)

Created:
4 years, 2 months ago by kozy
Modified:
4 years, 2 months ago
Reviewers:
dgozman
CC:
v8-reviews_googlegroups.com, devtools-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[inspector] fixed one more size_t -> int conversion This problem was detected only on linux64_gyp bot. It's safe to convert length string into int from size_t. R=dgozman@chromium.org Committed: https://crrev.com/3b6c7f04a9c0618fdd353b17e8712c6418e5f546 Cr-Commit-Position: refs/heads/master@{#40101}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M test/inspector/inspector-test.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
kozy
Dmitry, please take a look. It wasn't detected by running try bots in my previous ...
4 years, 2 months ago (2016-10-07 21:43:34 UTC) #1
dgozman
lgtm
4 years, 2 months ago (2016-10-07 21:44:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2402583004/1
4 years, 2 months ago (2016-10-07 21:59:03 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-07 22:15:49 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-10-07 22:16:18 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3b6c7f04a9c0618fdd353b17e8712c6418e5f546
Cr-Commit-Position: refs/heads/master@{#40101}

Powered by Google App Engine
This is Rietveld 408576698