Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1389)

Unified Diff: content/public/test/test_utils.h

Issue 2402553005: Do not run a nested loop in content::DeferredQuitRunLoop. (Closed)
Patch Set: fix OneClickSigninDialogViewTest Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/test/test_utils.h
diff --git a/content/public/test/test_utils.h b/content/public/test/test_utils.h
index 84d9e9539c075d854963ef08f07674155b484f86..d479eb5afe1a0636b1a8be1db6e412c6c37989e7 100644
--- a/content/public/test/test_utils.h
+++ b/content/public/test/test_utils.h
@@ -48,11 +48,12 @@ void RunThisRunLoop(base::RunLoop* run_loop);
// Turns on nestable tasks, runs all pending tasks in the message loop,
// then resets nestable tasks to what they were originally. Prefer this
// over MessageLoop::RunAllPending for in process browser tests to run
-// all pending tasks.
+// all pending tasks. Can only be called from the UI thread.
void RunAllPendingInMessageLoop();
// Blocks the current thread until all the pending messages in the loop of the
-// thread |thread_id| have been processed.
+// thread |thread_id| have been processed. Can only be called from the UI
+// thread.
void RunAllPendingInMessageLoop(BrowserThread::ID thread_id);
// Runs until both the blocking pool and the current message loop are empty
« no previous file with comments | « chrome/browser/ui/views/sync/one_click_signin_dialog_view_unittest.cc ('k') | content/public/test/test_utils.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698