Do not run a nested loop in content::DeferredQuitRunLoop.

chrome/browser/ui/views/sync/one_click_signin_dialog_view_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/sync/one_click_signin_dialog_view.h"
 
 #include <memory>
 #include <utility>
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/macros.h"
 #include "base/memory/ptr_util.h"
+#include "base/run_loop.h"
 #include "chrome/browser/ui/sync/one_click_signin_links_delegate.h"
 #include "chrome/browser/ui/views/chrome_constrained_window_views_client.h"
 #include "components/constrained_window/constrained_window_views.h"
-#include "content/public/test/test_utils.h"
 #include "ui/events/event_utils.h"
 #include "ui/views/controls/button/label_button.h"
 #include "ui/views/test/views_test_base.h"
 #include "ui/views/widget/widget.h"
 #include "ui/views/widget/widget_observer.h"
 #include "ui/views/window/dialog_client_view.h"
 
 class OneClickSigninDialogViewTest : public views::ViewsTestBase,
                                      public views::WidgetObserver {
  public:
@@ skipping 87 matching lines @@
 
   // Widget to host the anchor view of the dialog. Destroys itself when closed.
   views::Widget* anchor_widget_ = nullptr;
   base::RunLoop* run_loop_ = nullptr;
 
   DISALLOW_COPY_AND_ASSIGN(OneClickSigninDialogViewTest);
 };
 
 TEST_F(OneClickSigninDialogViewTest, ShowDialog) {
   ShowOneClickSigninDialog();
-  content::RunAllPendingInMessageLoop();
+  base::RunLoop().RunUntilIdle();
   EXPECT_TRUE(OneClickSigninDialogView::IsShowing());
 }
 
 TEST_F(OneClickSigninDialogViewTest, HideDialog) {
   ShowOneClickSigninDialog();
 
   OneClickSigninDialogView::Hide();
   WaitForClose();
   EXPECT_FALSE(OneClickSigninDialogView::IsShowing());
   EXPECT_TRUE(on_start_sync_called_);
@@ skipping 47 matching lines @@
 }
 
 TEST_F(OneClickSigninDialogViewTest, LearnMoreLink) {
   OneClickSigninDialogView* view = ShowOneClickSigninDialog();
 
   views::LinkListener* listener = view;
   listener->LinkClicked(view->learn_more_link_, 0);
 
   // View should still be showing and the OnLearnMoreLinkClicked method
   // of the delegate should have been called with |is_dialog| == true.
-  content::RunAllPendingInMessageLoop();
+  base::RunLoop().RunUntilIdle();
   EXPECT_TRUE(OneClickSigninDialogView::IsShowing());
   EXPECT_EQ(1, learn_more_click_count_);
 }
 
 TEST_F(OneClickSigninDialogViewTest, PressEnterKey) {
   OneClickSigninDialogView* one_click_view = ShowOneClickSigninDialog();
   ui::KeyEvent event(ui::ET_KEY_PRESSED, ui::VKEY_RETURN, 0);
   one_click_view->GetWidget()->OnKeyEvent(&event);
 
   WaitForClose();
   EXPECT_FALSE(OneClickSigninDialogView::IsShowing());
   EXPECT_TRUE(on_start_sync_called_);
   EXPECT_EQ(OneClickSigninSyncStarter::SYNC_WITH_DEFAULT_SETTINGS, mode_);
 }
 
 TEST_F(OneClickSigninDialogViewTest, PressEscapeKey) {
   OneClickSigninDialogView* one_click_view = ShowOneClickSigninDialog();
   ui::KeyEvent event(ui::ET_KEY_PRESSED, ui::VKEY_ESCAPE, 0);
   one_click_view->GetWidget()->OnKeyEvent(&event);
 
   WaitForClose();
   EXPECT_FALSE(OneClickSigninDialogView::IsShowing());
   EXPECT_TRUE(on_start_sync_called_);
   EXPECT_EQ(OneClickSigninSyncStarter::UNDO_SYNC, mode_);
 }