Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2350)

Unified Diff: chrome/browser/resources/settings/search_engines_page/search_engine_entry.html

Issue 2402553002: MD Settings: Implementing modal popup/action menus. (Closed)
Patch Set: Address comments. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/search_engines_page/search_engine_entry.html
diff --git a/chrome/browser/resources/settings/search_engines_page/search_engine_entry.html b/chrome/browser/resources/settings/search_engines_page/search_engine_entry.html
index e467d92a89a36f41a39f39923e1030ee2319c2b3..55b3bb900495d88b3e4ba6117209508603e54527 100644
--- a/chrome/browser/resources/settings/search_engines_page/search_engine_entry.html
+++ b/chrome/browser/resources/settings/search_engines_page/search_engine_entry.html
@@ -5,6 +5,7 @@
<link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper-icon-button.html">
<link rel="import" href="/search_engines_page/search_engine_dialog.html">
<link rel="import" href="/search_engines_page/search_engines_browser_proxy.html">
+<link rel="import" href="/settings_action_menu.html">
<link rel="import" href="/settings_shared_css.html">
<dom-module id="settings-search-engine-entry">
@@ -41,24 +42,21 @@
</div>
<div class="keyword-column">[[engine.keyword]]</div>
<div class="url-column">[[engine.url]]</div>
- <paper-icon-button icon="cr:more-vert" toggles tabindex$="[[tabindex]]"
- active="{{editMenuOpened}}">
+ <paper-icon-button icon="cr:more-vert" tabindex$="[[tabindex]]"
+ on-tap="onDotsTap_">
</paper-icon-button>
- <iron-dropdown opened="{{editMenuOpened}}" horizontal-align="right"
- vertical-align="auto">
- <div class="dropdown-content">
- <button class="dropdown-item" role="option" on-tap="onMakeDefaultTap_"
- hidden$="[[!engine.canBeDefault]]" id="makeDefault">
- $i18n{searchEnginesMakeDefault}
- </button>
- <button class="dropdown-item" role="option" on-tap="onEditTap_"
- hidden$="[[!engine.canBeEdited]]"
- id="edit">$i18n{searchEnginesEdit}</button>
- <button class="dropdown-item" role="option" on-tap="onDeleteTap_"
- hidden$="[[!engine.canBeRemoved]]"
- id="delete">$i18n{searchEnginesRemoveFromList}</button>
- <div>
- </iron-dropdown>
+ <dialog is="settings-action-menu">
+ <button class="dropdown-item" role="option" on-tap="onMakeDefaultTap_"
+ hidden$="[[!engine.canBeDefault]]" id="makeDefault">
+ $i18n{searchEnginesMakeDefault}
+ </button>
+ <button class="dropdown-item" role="option" on-tap="onEditTap_"
+ hidden$="[[!engine.canBeEdited]]"
+ id="edit">$i18n{searchEnginesEdit}</button>
+ <button class="dropdown-item" role="option" on-tap="onDeleteTap_"
+ hidden$="[[!engine.canBeRemoved]]"
+ id="delete">$i18n{searchEnginesRemoveFromList}</button>
+ </dialog>
</div>
</template>
<script src="search_engine_entry.js"></script>

Powered by Google App Engine
This is Rietveld 408576698