chrome/browser/resources/settings/search_engines_page/search_engine_entry.js - Issue 2402553002: MD Settings: Implementing modal popup/action menus.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/search_engines_page/search_engine_entry.js

Issue 2402553002: MD Settings: Implementing modal popup/action menus. (Closed)

Patch Set: Address comments. Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/settings/languages_page/languages_page.html ('K') | « chrome/browser/resources/settings/search_engines_page/search_engine_entry.html ('k') | chrome/browser/resources/settings/settings_action_menu.html » ('j') | chrome/browser/resources/settings/settings_action_menu.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/search_engines_page/search_engine_entry.js

diff --git a/chrome/browser/resources/settings/search_engines_page/search_engine_entry.js b/chrome/browser/resources/settings/search_engines_page/search_engine_entry.js

index 5a33a8757e30841460ad6fc62290b8e7da8d55bb..b458c4658d692b8aa4d440915457c0fb8e72603e 100644

--- a/chrome/browser/resources/settings/search_engines_page/search_engine_entry.js

+++ b/chrome/browser/resources/settings/search_engines_page/search_engine_entry.js

@@ -69,7 +69,7 @@ Polymer({

/** @private */

closePopupMenu_: function() {

- this.$$('iron-dropdown').close();

+ this.$$('dialog[is=settings-action-menu]').close();

/**

@@ -81,4 +81,10 @@ Polymer({

// Force default icon, if no |engine.iconURL| is available.

return cr.icon.getFavicon(url || '');

+ onDotsTap_: function(e) {

+ var rect = this.$$('paper-icon-button').getBoundingClientRect();

+ /** @type {!SettingsActionMenuElement} */ (

+ this.$$('dialog[is=settings-action-menu]')).showAtLocation(rect);

+ },

});