chrome/browser/resources/settings/settings_action_menu.html - Issue 2402553002: MD Settings: Implementing modal popup/action menus.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/settings/settings_action_menu.html

Issue 2402553002: MD Settings: Implementing modal popup/action menus. (Closed)

Patch Set: Address comments. Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <link rel="import" href="chrome://resources/html/polymer.html">

	2 <link rel="import" href="/direction_delegate.html">

	3

	4 <dom-module id="settings-action-menu">

	5 <template>

	6 <style>

	7 :host {

	8 background-color: white;

	9 border: none;

	10 box-shadow: 0 2px 6px var(--paper-grey-500);
	Dan Beam 2016/10/13 05:03:01 is it possible to share this somehow with wherever is it possible to share this somehow with wherever you're copying from? dpapad 2016/10/13 18:18:00 This is copied from https://cs.chromium.org/chromi Show quoted text On 2016/10/13 at 05:03:01, Dan Beam wrote: > is it possible to share this somehow with wherever you're copying from? This is copied from https://cs.chromium.org/chromium/src/chrome/browser/resources/settings/settin.... When the migration to settings-action-menu is done, there will be no iron-dropdown in the codebase, and there will be no copying (the CSS rule will be deleted from settings_shared_css.html). The one here should be the only occurrence. So I am not inclined to share it with a soon to be gone code.
	11 margin: 0;

	12 outline: none;

	13 padding: 0;

	14 }

	15

	16 :host::backdrop {

	17 background-color: transparent;

	18 }

	19 </style>

	20 <content select=".dropdown-item,hr"></content>

	21 </template>

	22 <script src="settings_action_menu.js"></script>

	23 </dom-module>

OLD	NEW