Create a BotEvent when a bot is leased from Machine Provider

Create a BotEvent when a bot is leased from Machine Provider

Creating a BotEvent also ensures a BotInfo exists.

BUG=627560
Committed: https://github.com/luci/luci-py/commit/ef58021b34ac471545c8d7e9213246de045f2640

[smut, 2016-10-06 22:44:43]

Patchset #1 (id:1) has been deleted

[smut, 2016-10-06 22:49:25]

smut@google.com changed reviewers:
+ maruel@chromium.org

[smut, 2016-10-06 22:49:26]

Calling bot_management.bot_event is currently the only way to create a BotInfo,
so I added a new event type so we can keep using that existing code path.

The lease ID I added is a globally unique ID that can be used to look up leases
in the Machine Provider, so we can use that to generate the link to MP.

[M-A Ruel, 2016-10-06 23:37:28]

+Kevin for UI
+Ryan fyi

lgtm

https://codereview.chromium.org/2402543002/diff/20001/appengine/swarming/serv...
File appengine/swarming/server/bot_management.py (right):

https://codereview.chromium.org/2402543002/diff/20001/appengine/swarming/serv...
appengine/swarming/server/bot_management.py:91: lease_expiration_ts =
ndb.DateTimeProperty()
I'd say indexed=False here too (?)

https://codereview.chromium.org/2402543002/diff/20001/appengine/swarming/serv...
File appengine/swarming/server/lease_management.py (right):

https://codereview.chromium.org/2402543002/diff/20001/appengine/swarming/serv...
appengine/swarming/server/lease_management.py:437: dimensions={
I guess it's fine to not put any (?)

In that case, I'd like BotInfo to not loose its dimensions.

[smut, 2016-10-06 23:48:50]

https://codereview.chromium.org/2402543002/diff/20001/appengine/swarming/serv...
File appengine/swarming/server/bot_management.py (right):

https://codereview.chromium.org/2402543002/diff/20001/appengine/swarming/serv...
appengine/swarming/server/bot_management.py:91: lease_expiration_ts =
ndb.DateTimeProperty()
On 2016/10/06 23:37:28, M-A Ruel wrote:
> I'd say indexed=False here too (?)

Done. I thought it was default False for DateTimeProperty but the docs don't
say.

https://codereview.chromium.org/2402543002/diff/20001/appengine/swarming/serv...
File appengine/swarming/server/lease_management.py (right):

https://codereview.chromium.org/2402543002/diff/20001/appengine/swarming/serv...
appengine/swarming/server/lease_management.py:437: dimensions={
On 2016/10/06 23:37:28, M-A Ruel wrote:
> I guess it's fine to not put any (?)
> 
> In that case, I'd like BotInfo to not loose its dimensions.

Done.

It looks kind of funny in the UI if this is the first event. You get a really
short row because there are no dimensions or state, only one line in one column
for bot ID. Bot eventually self-reports correct dimensions and overwrites what's
set here on next poll at any rate.

[smut, 2016-10-07 21:43:43]

On 2016/10/06 23:37:28, M-A Ruel wrote:
> +Kevin for UI

He landed a follow up in https://codereview.chromium.org/2403543002/ so I assume
he's okay with the changes.

[smut, 2016-10-07 21:43:46]

The CQ bit was checked by smut@google.com

[smut, 2016-10-07 21:43:46]

The patchset sent to the CQ was uploaded after l-g-t-m from maruel@chromium.org
Link to the patchset: https://codereview.chromium.org/2402543002/#ps40001
(title: "Fix")

[commit-bot: I haz the power, 2016-10-07 21:43:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-07 21:50:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-07 21:50:42]

Try jobs failed on following builders:
  Luci-py Presubmit on luci.infra.try (JOB_FAILED,
https://luci-milo.appspot.com/swarming/task/31b9eef34706bb10)

[smut, 2016-10-07 22:11:10]

The CQ bit was checked by smut@google.com

[smut, 2016-10-07 22:11:10]

The patchset sent to the CQ was uploaded after l-g-t-m from maruel@chromium.org
Link to the patchset: https://codereview.chromium.org/2402543002/#ps60001
(title: "Fix tests")

[commit-bot: I haz the power, 2016-10-07 22:11:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-07 22:14:38]

Description was changed from

==========
Create a BotEvent when a bot is leased from Machine Provider

Creating a BotEvent also ensures a BotInfo exists.

BUG=627560
==========

to

==========
Create a BotEvent when a bot is leased from Machine Provider

Creating a BotEvent also ensures a BotInfo exists.

BUG=627560

Committed:
https://github.com/luci/luci-py/commit/ef58021b34ac471545c8d7e9213246de045f2640
==========

[commit-bot: I haz the power, 2016-10-07 22:14:38]

Committed patchset #3 (id:60001) as
https://github.com/luci/luci-py/commit/ef58021b34ac471545c8d7e9213246de045f2640