Issue 240253006: Remove --disable-accelerated-video and GPU_FEATURE_TYPE_ACCELERATED_VIDEO

Issue 240253006: Remove --disable-accelerated-video and GPU_FEATURE_TYPE_ACCELERATED_VIDEO (Closed)

Created:
6 years, 8 months ago by piman

Modified:
6 years, 8 months ago

Reviewers:
danakj, darin (slow to review)

CC:
chromium-reviews, piman+watch_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove --disable-accelerated-video and GPU_FEATURE_TYPE_ACCELERATED_VIDEO These are just compositing triggers. GPU_FEATURE_TYPE_ACCELERATED_VIDEO is completely ignored, and there's no reason to disable the compositing trigger since FCM is always on in production. BUG=362164 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266354

Patch Set 1 #

Total comments: 2

Patch Set 2 : set accelerated_compositing_for_video_enabled to true in constructor #

Patch Set 3 : rebase #

Patch Set 4 : rebase #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -27 lines)			Patch
M	content/browser/gpu/compositor_util.cc	View	1 2 3	1 chunk	+0 lines, -9 lines	0 comments	Download
M	content/browser/gpu/gpu_data_manager_impl_private.cc	View	1 2 3	1 chunk	+0 lines, -2 lines	0 comments	Download
M	content/browser/renderer_host/render_view_host_impl.cc	View	1 2 3	1 chunk	+0 lines, -2 lines	0 comments	Download
M	content/browser/resources/gpu/info_view.js	View	1 2 3	1 chunk	+0 lines, -1 line	0 comments	Download
M	content/public/common/content_switches.h	View	1 2 3	1 chunk	+0 lines, -1 line	0 comments	Download
M	content/public/common/content_switches.cc	View	1 2 3	1 chunk	+0 lines, -3 lines	0 comments	Download
M	gpu/config/gpu_blacklist.cc	View	1 2 3	1 chunk	+0 lines, -2 lines	0 comments	Download
M	gpu/config/gpu_blacklist_unittest.cc	View	1 2 3	1 chunk	+0 lines, -4 lines	0 comments	Download
M	gpu/config/gpu_feature_type.h	View	1 2 3	1 chunk	+0 lines, -1 line	0 comments	Download
M	gpu/config/software_rendering_list_json.cc	View	1 2 3	1 chunk	+0 lines, -1 line	0 comments	Download
M	webkit/common/webpreferences.cc	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

danakj

LGTM https://codereview.chromium.org/240253006/diff/1/content/browser/renderer_host/render_view_host_impl.cc File content/browser/renderer_host/render_view_host_impl.cc (right): https://codereview.chromium.org/240253006/diff/1/content/browser/renderer_host/render_view_host_impl.cc#newcode432 content/browser/renderer_host/render_view_host_impl.cc:432: prefs.accelerated_compositing_for_video_enabled = true; can set true in the ...

6 years, 8 months ago (2014-04-16 22:35:41 UTC) #2

piman

+darin for OWNERs in webkit/ https://codereview.chromium.org/240253006/diff/1/content/browser/renderer_host/render_view_host_impl.cc File content/browser/renderer_host/render_view_host_impl.cc (right): https://codereview.chromium.org/240253006/diff/1/content/browser/renderer_host/render_view_host_impl.cc#newcode432 content/browser/renderer_host/render_view_host_impl.cc:432: prefs.accelerated_compositing_for_video_enabled = true; On ...

6 years, 8 months ago (2014-04-16 22:48:20 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/piman@chromium.org/240253006/50001

6 years, 8 months ago (2014-04-25 22:06:54 UTC) #5

Message was sent while issue was closed.

Change committed as 266354

Expand Messages | Collapse Messages