Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 2402513004: [Devtools] Fixed flakey network test (Closed)

Created:
4 years, 2 months ago by allada
Modified:
4 years, 2 months ago
Reviewers:
dgozman, lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Devtools] Fixed flakey network test Fixed flakeyness caused from using requestAnimationFrame instead of setTimeout caused from other patch. R=lushnikov,dgozman BUG=652968 Committed: https://crrev.com/9df2e85336f13ab0cf884e72102912866944a7a8 Cr-Commit-Position: refs/heads/master@{#423974}

Patch Set 1 #

Patch Set 2 : Merge branch 'master' into FIX_COLUMNS_TEST #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -2 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/network/network-columns-visible.html View 1 chunk +24 lines, -1 line 0 comments Download

Messages

Total messages: 13 (6 generated)
allada
PTL [tested locally with --repeat-each=1000 with zero failures]
4 years, 2 months ago (2016-10-07 19:16:06 UTC) #1
dgozman
lgtm
4 years, 2 months ago (2016-10-07 19:21:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2402513004/1
4 years, 2 months ago (2016-10-07 19:23:30 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/82768) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years, 2 months ago (2016-10-07 19:25:57 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2402513004/40001
4 years, 2 months ago (2016-10-07 20:57:21 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 2 months ago (2016-10-07 21:48:14 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-10-07 21:49:47 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9df2e85336f13ab0cf884e72102912866944a7a8
Cr-Commit-Position: refs/heads/master@{#423974}

Powered by Google App Engine
This is Rietveld 408576698