Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 2402513003: Function Implementation for pure virtual functions missing in derived class

Created:
4 years, 2 months ago by mayank.g1
Modified:
4 years, 2 months ago
Reviewers:
a.suchit2
CC:
chromium-reviews, jam, sievers+watch_chromium.org, jbauman+watch_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, kalyank, danakj+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Function Implementation for pure virtual functions missing in derived class Below function are marked as pure virtual in "OutputSurface" Class void EnsureBackbuffer() void DiscardBackbuffer() void BindFramebuffer() bool IsDisplayedAsOverlayPlane() unsigned GetOverlayTextureId() bool SurfaceIsSuspendForRecycle() uint32_t GetFramebufferCopyTextureFormat() These function were not implemented in "VulkanBrowserCompositorOutputSurface" Class. BUG=582558, 582564

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -0 lines) Patch
M content/browser/compositor/vulkan_browser_compositor_output_surface.h View 1 chunk +7 lines, -0 lines 0 comments Download
M content/browser/compositor/vulkan_browser_compositor_output_surface.cc View 1 chunk +32 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (2 generated)
a.suchit2
4 years, 2 months ago (2016-10-10 10:54:04 UTC) #3
Please upload a single patch for all the build issues in vulkan.

peer review not looks good to me.

Powered by Google App Engine
This is Rietveld 408576698