Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(631)

Unified Diff: Source/core/dom/Document.cpp

Issue 24025002: The content='...' parsing error is not a viewport error, so keep it separate (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/core/dom/ViewportArguments.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/dom/Document.cpp
diff --git a/Source/core/dom/Document.cpp b/Source/core/dom/Document.cpp
index 374b38cd737e201164dc1ef6123a0c5d0a044689..a404e0628a04d0a8ee2bef2baa944badbe48a6c8 100644
--- a/Source/core/dom/Document.cpp
+++ b/Source/core/dom/Document.cpp
@@ -3030,8 +3030,10 @@ void Document::processArguments(const String& features, void* data, ArgumentsCal
String valueString = buffer.substring(valueBegin, valueEnd - valueBegin);
callback(keyString, valueString, this, data);
}
- if (error)
- reportViewportWarning(this, InvalidKeyValuePairSeparatorError, String(), String());
+ if (error) {
+ String message = "Note that ';' is not a key-value pair separator. The list should be comma-separated.";
Mike West 2013/09/06 12:17:47 Since you're changing this anyway, I'd suggest mak
+ addConsoleMessage(OtherMessageSource, WarningMessageLevel, message);
Mike West 2013/09/06 12:17:47 I believe this should be 'RenderingMessageSource'.
+ }
}
void Document::processViewport(const String& features, ViewportArguments::Type origin)
« no previous file with comments | « no previous file | Source/core/dom/ViewportArguments.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698