Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 2402463002: Fix link failure on //tools/clang/base_bind_rewriters (Closed)

Created:
4 years, 2 months ago by tzik
Modified:
4 years, 2 months ago
Reviewers:
dcheng
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix link failure on //tools/clang/base_bind_rewriters Committed: https://crrev.com/84c65c96975778e8b4f4207612be68f2c7d39a99 Cr-Commit-Position: refs/heads/master@{#423780}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M tools/clang/base_bind_rewriters/CMakeLists.txt View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
tzik
PTAL. We can build the tool successfully throgh //tools/clang/scripts/update.py for some reason, but it has ...
4 years, 2 months ago (2016-10-06 15:44:05 UTC) #2
dcheng
On 2016/10/06 15:44:05, tzik wrote: > PTAL. We can build the tool successfully throgh //tools/clang/scripts/update.py ...
4 years, 2 months ago (2016-10-06 15:46:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2402463002/1
4 years, 2 months ago (2016-10-07 02:02:51 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-07 02:15:58 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-10-07 02:17:54 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/84c65c96975778e8b4f4207612be68f2c7d39a99
Cr-Commit-Position: refs/heads/master@{#423780}

Powered by Google App Engine
This is Rietveld 408576698