Add missing dependencies to extensions BUILD.gns

Add missing dependencies to extensions BUILD.gns

Some files from guest_view include (not directly) file
extensions/common/api/events.h which is generated by target
//extensions/common/api. This dependency is missing and
sometimes it causes compilation errors. Build will fail if
no target which depends on //extensions/common/api is built
before guest_view. It happens quite rarely: it failed once
on ~10 rebuilds on my mac.

BUG=

Committed: https://crrev.com/fcad3151eb07e3ac02a68ba89eaa2fff9c5c2c3d
Cr-Commit-Position: refs/heads/master@{#423613}

[ckulakowski, 2016-10-06 15:29:51]

Description was changed from

==========
Add missing dependencies to extensions BUILD.gns

Files from guest_view include extensions/common/api/events.h which
is generated by target //extensions/common/api. This dependency is
missing and it causes seldom compilation errors.

BUG=
==========

to

==========
Add missing dependencies to extensions BUILD.gns

Files from guest_view include extensions/common/api/events.h which
is generated by target //extensions/common/api. This dependency is
missing and it causes seldom compilation errors.

BUG=
==========

[ckulakowski, 2016-10-06 15:29:52]

ckulakowski@opera.com changed reviewers:
+ lfg@chromium.org, wjmaclean@chromium.org

[ckulakowski, 2016-10-06 15:30:52]

ckulakowski@opera.com changed reviewers:
+ paulmeyer@chromium.org

[wjmaclean, 2016-10-06 15:39:23]

On 2016/10/06 15:30:18, ckulakowski wrote:

I searched for files that include extensions/common/api/events.h, and didn't
find anything under extensions/browser/guest_view *directly* using it ... is it
something indirectly used?

Nit: the wording of the issue description is confusing. Does the bug
"occasionally" cause errors? "Seldom" seems like the wrong word here. Perhaps it
would be even better if we could say something about the specific cases where
this causes compilation errors?

LGTM modulo answering the questions above.

[ckulakowski, 2016-10-06 15:48:15]

On 2016/10/06 15:39:23, wjmaclean wrote:
> On 2016/10/06 15:30:18, ckulakowski wrote:
> 
> I searched for files that include extensions/common/api/events.h, and didn't
> find anything under extensions/browser/guest_view *directly* using it ... is
it
> something indirectly used?
> 
> Nit: the wording of the issue description is confusing. Does the bug
> "occasionally" cause errors? "Seldom" seems like the wrong word here. Perhaps
it
> would be even better if we could say something about the specific cases where
> this causes compilation errors?
> 
> LGTM modulo answering the questions above.

It's not included directly. Here is full inclusion path (one of few):
In file included from
../../extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc:18:
In file included from ../../extensions/browser/api/extensions_api_client.h:12:
In file included from
../../extensions/browser/api/declarative_content/content_rules_registry.h:12:
../../extensions/browser/api/declarative/rules_registry.h:24:10: fatal error:
'extensions/common/api/events.h' file not found
#include "extensions/common/api/events.h"

Build sometimes fails. It depends which target will build first (it's quite
random, from my observations). If some other target which depends on
//extensions/common/api is built before guest_view error won't occur. It failed
once on ~10 rebuilds so it doesn't occur often.

[wjmaclean, 2016-10-06 15:52:43]

On 2016/10/06 15:48:15, ckulakowski wrote:
> On 2016/10/06 15:39:23, wjmaclean wrote:
> > On 2016/10/06 15:30:18, ckulakowski wrote:
> > 
> > I searched for files that include extensions/common/api/events.h, and didn't
> > find anything under extensions/browser/guest_view *directly* using it ... is
> it
> > something indirectly used?
> > 
> > Nit: the wording of the issue description is confusing. Does the bug
> > "occasionally" cause errors? "Seldom" seems like the wrong word here.
Perhaps
> it
> > would be even better if we could say something about the specific cases
where
> > this causes compilation errors?
> > 
> > LGTM modulo answering the questions above.
> 
> It's not included directly. Here is full inclusion path (one of few):
> In file included from
>
../../extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc:18:
> In file included from ../../extensions/browser/api/extensions_api_client.h:12:
> In file included from
> ../../extensions/browser/api/declarative_content/content_rules_registry.h:12:
> ../../extensions/browser/api/declarative/rules_registry.h:24:10: fatal error:
> 'extensions/common/api/events.h' file not found
> #include "extensions/common/api/events.h"
> 
> Build sometimes fails. It depends which target will build first (it's quite
> random, from my observations). If some other target which depends on
> //extensions/common/api is built before guest_view error won't occur. It
failed
> once on ~10 rebuilds so it doesn't occur often.

So can you please add this information to the issue description then? Not all of
it, but a suitable summary.

[ckulakowski, 2016-10-06 15:59:28]

Description was changed from

==========
Add missing dependencies to extensions BUILD.gns

Files from guest_view include extensions/common/api/events.h which
is generated by target //extensions/common/api. This dependency is
missing and it causes seldom compilation errors.

BUG=
==========

to

==========
Add missing dependencies to extensions BUILD.gns

Some files from guest_view include (not directly) file
extensions/common/api/events.h which is generated by target
//extensions/common/api. This dependency is missing and sometimes it causes
compilation errors. Build will fail if no target which depends on
//extensions/common/api is built before guest_view. It happens quite rarely: it
failed once on ~10 rebuilds on my mac.

BUG=
==========

[ckulakowski, 2016-10-06 16:03:15]

> So can you please add this information to the issue description then? Not all
of
> it, but a suitable summary.

I've updated description. Is it good enough? :)

[wjmaclean, 2016-10-06 16:36:29]

On 2016/10/06 16:03:15, ckulakowski wrote:
> > So can you please add this information to the issue description then? Not
all
> of
> > it, but a suitable summary.
> 
> I've updated description. Is it good enough? :)

The description looks much better, thank you. Can you get it to wrap at 72 chars
please? Then it's probably good to go.

[ckulakowski, 2016-10-06 16:39:47]

Description was changed from

==========
Add missing dependencies to extensions BUILD.gns

Some files from guest_view include (not directly) file
extensions/common/api/events.h which is generated by target
//extensions/common/api. This dependency is missing and sometimes it causes
compilation errors. Build will fail if no target which depends on
//extensions/common/api is built before guest_view. It happens quite rarely: it
failed once on ~10 rebuilds on my mac.

BUG=
==========

to

==========
Add missing dependencies to extensions BUILD.gns

Some files from guest_view include (not directly) file
extensions/common/api/events.h which is generated by target
//extensions/common/api. This dependency is missing and
sometimes it causes compilation errors. Build will fail if
no target which depends on //extensions/common/api is built
before guest_view. It happens quite rarely: it failed once
on ~10 rebuilds on my mac.

BUG=
==========

[ckulakowski, 2016-10-06 16:40:22]

The CQ bit was checked by ckulakowski@opera.com

[commit-bot: I haz the power, 2016-10-06 16:40:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-06 18:56:38]

Description was changed from

==========
Add missing dependencies to extensions BUILD.gns

Some files from guest_view include (not directly) file
extensions/common/api/events.h which is generated by target
//extensions/common/api. This dependency is missing and
sometimes it causes compilation errors. Build will fail if
no target which depends on //extensions/common/api is built
before guest_view. It happens quite rarely: it failed once
on ~10 rebuilds on my mac.

BUG=
==========

to

==========
Add missing dependencies to extensions BUILD.gns

Some files from guest_view include (not directly) file
extensions/common/api/events.h which is generated by target
//extensions/common/api. This dependency is missing and
sometimes it causes compilation errors. Build will fail if
no target which depends on //extensions/common/api is built
before guest_view. It happens quite rarely: it failed once
on ~10 rebuilds on my mac.

BUG=
==========

[commit-bot: I haz the power, 2016-10-06 18:56:39]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-10-06 18:59:52]

Description was changed from

==========
Add missing dependencies to extensions BUILD.gns

Some files from guest_view include (not directly) file
extensions/common/api/events.h which is generated by target
//extensions/common/api. This dependency is missing and
sometimes it causes compilation errors. Build will fail if
no target which depends on //extensions/common/api is built
before guest_view. It happens quite rarely: it failed once
on ~10 rebuilds on my mac.

BUG=
==========

to

==========
Add missing dependencies to extensions BUILD.gns

Some files from guest_view include (not directly) file
extensions/common/api/events.h which is generated by target
//extensions/common/api. This dependency is missing and
sometimes it causes compilation errors. Build will fail if
no target which depends on //extensions/common/api is built
before guest_view. It happens quite rarely: it failed once
on ~10 rebuilds on my mac.

BUG=

Committed: https://crrev.com/fcad3151eb07e3ac02a68ba89eaa2fff9c5c2c3d
Cr-Commit-Position: refs/heads/master@{#423613}
==========

[commit-bot: I haz the power, 2016-10-06 18:59:53]

Patchset 1 (id:??) landed as
https://crrev.com/fcad3151eb07e3ac02a68ba89eaa2fff9c5c2c3d
Cr-Commit-Position: refs/heads/master@{#423613}