Update HTMLElement.dir / Document.dir to return only known values

Source/core/dom/Document.cpp

Index: Source/core/dom/Document.cpp
diff --git a/Source/core/dom/Document.cpp b/Source/core/dom/Document.cpp
index 94af56c0c40277a1b7c5976aefe59891e6418b9f..42743cb011574c585b48ca725e3881ffcac71507 100644
--- a/Source/core/dom/Document.cpp
+++ b/Source/core/dom/Document.cpp
@@ -125,6 +125,7 @@
 #include "core/html/HTMLDocument.h"
 #include "core/html/HTMLFrameOwnerElement.h"
 #include "core/html/HTMLHeadElement.h"
+#include "core/html/HTMLHtmlElement.h"
 #include "core/html/HTMLIFrameElement.h"
 #include "core/html/HTMLInputElement.h"
 #include "core/html/HTMLLinkElement.h"
@@ -1394,10 +1395,8 @@ void Document::removeTitle(Element* titleElement)
 const AtomicString& Document::dir()
 {
     Element* rootElement = documentElement();
-    if (isHTMLHtmlElement(rootElement)) {
-        // FIXME(crbug.com/363628): document.dir should only return known values.
-        return rootElement->getAttribute(dirAttr);
-    }
+    if (isHTMLHtmlElement(rootElement))
+        return toHTMLHtmlElement(rootElement)->dir();

[Inactive, 2014/04/16 18:05:54]

By not using [Reflect] for HTMLElement.dir, I can call HTMLElement::dir() here
and only have the "known value" checking code in one place.

Unless I am mistaken, if I use [ReflectOnly=xxx] for HTMLElement.dir, then the
"known value" checking code will be in the bindings and won't be reusable here,
right?

[sof, 2014/04/16 18:19:05]

The binding layer will implement the limited-to-only-known-values handling, so
if N attributes have the same set, there will be N copies of that code. Small
pieces of code, arguably.

     return nullAtom;
 }
 
@@ -1405,7 +1404,7 @@ void Document::setDir(const AtomicString& value)
 {
     Element* rootElement = documentElement();
     if (isHTMLHtmlElement(rootElement))
-        rootElement->setAttribute(dirAttr, value);
+        toHTMLHtmlElement(rootElement)->setDir(value);
 }
 
 PageVisibilityState Document::pageVisibilityState() const