Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(839)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: scripts/common/archive_utils.py

Issue 2402423002: Enable saving the same file in multiple archives (Closed)
Patch Set: Follow-up fix broken build Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | scripts/common/archive_utils_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/common/archive_utils.py
diff --git a/scripts/common/archive_utils.py b/scripts/common/archive_utils.py
index 32b45f29e3dbd34a1952aed708f4cfc30bdde141..406c876a63431b5a8b34efa509ddecd233448ee1 100644
--- a/scripts/common/archive_utils.py
+++ b/scripts/common/archive_utils.py
@@ -137,7 +137,7 @@ class FilesCfgParser(object):
for fileobj in self._files_list:
if fileobj['filename'] == filename:
found_optional = True
- if self._buildtype not in fileobj['optional']:
+ if self._buildtype not in fileobj.get('optional', []):
return False
return found_optional
« no previous file with comments | « no previous file | scripts/common/archive_utils_unittest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698