Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 24024007: Simplify process exit-code handling on Posix. (Closed)

Created:
7 years, 3 months ago by Anders Johnsen
Modified:
7 years, 3 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Simplify process exit-code handling on Posix. We now only use waitpid and not signals. When we exit, we perform a small fork-and-exit to interrupt waitpid, so it can exit the thread. BUG= R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=27247

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+126 lines, -371 lines) Patch
M runtime/bin/process_android.cc View 5 chunks +42 lines, -124 lines 0 comments Download
M runtime/bin/process_linux.cc View 5 chunks +42 lines, -124 lines 0 comments Download
M runtime/bin/process_macos.cc View 4 chunks +42 lines, -123 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Anders Johnsen
7 years, 3 months ago (2013-09-06 13:01:44 UTC) #1
Søren Gjesse
LGTM! Nice cleanup!
7 years, 3 months ago (2013-09-06 13:05:20 UTC) #2
Anders Johnsen
7 years, 3 months ago (2013-09-06 13:08:43 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r27247 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698