Issue 24024002: file_manager: Move mount test stuff to c/t/d/extensions/api_test/file_browser

Issue 24024002: file_manager: Move mount test stuff to c/t/d/extensions/api_test/file_browser (Closed)

Created:
7 years, 3 months ago by satorux1

Modified:
7 years, 3 months ago

Reviewers:
yoshiki, benwells

CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, rginda+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

file_manager: Move mount test stuff to c/t/d/extensions/api_test/file_browser To consolidate fileBrowserPrivate tests into a single directory. Als add OWNERS, so Files.app team can add tests without approval from extensions owners. BUG=231782 TEST=none R=benwells@chromium.org, yoshiki@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221987

Patch Set 1 : #

Total comments: 2

Patch Set 2 : fix OWNERS #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -235 lines)			Patch
M	chrome/browser/chromeos/extensions/file_manager/file_browser_private_apitest.cc	View		4 chunks	+7 lines, -6 lines	0 comments	Download
M	chrome/browser/resources/file_manager/OWNERS	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
A	chrome/test/data/extensions/api_test/file_browser/OWNERS	View		1 chunk	+4 lines, -0 lines	0 comments	Download
A +	chrome/test/data/extensions/api_test/file_browser/mount_test/background.js	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	chrome/test/data/extensions/api_test/file_browser/mount_test/manifest.json	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	chrome/test/data/extensions/api_test/file_browser/mount_test/test.html	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	chrome/test/data/extensions/api_test/file_browser/mount_test/test.js	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A	chrome/test/data/extensions/api_test/file_manager_browsertest/OWNERS	View		1 chunk	+4 lines, -0 lines	0 comments	Download
D	chrome/test/data/extensions/api_test/filebrowser_mount/background.js	View		1 chunk	+0 lines, -7 lines	0 comments	Download
D	chrome/test/data/extensions/api_test/filebrowser_mount/manifest.json	View		1 chunk	+0 lines, -14 lines	0 comments	Download
D	chrome/test/data/extensions/api_test/filebrowser_mount/test.html	View		1 chunk	+0 lines, -11 lines	0 comments	Download
D	chrome/test/data/extensions/api_test/filebrowser_mount/test.js	View		1 chunk	+0 lines, -199 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

yoshiki

lgtm with nit https://codereview.chromium.org/24024002/diff/3001/chrome/browser/resources/file_manager/OWNERS File chrome/browser/resources/file_manager/OWNERS (right): https://codereview.chromium.org/24024002/diff/3001/chrome/browser/resources/file_manager/OWNERS#newcode1 chrome/browser/resources/file_manager/OWNERS:1: # This should match chrome/browser/resources/file_manager/OWNERS nit: ...

7 years, 3 months ago (2013-09-06 06:40:55 UTC) #2

satorux1

https://codereview.chromium.org/24024002/diff/3001/chrome/browser/resources/file_manager/OWNERS File chrome/browser/resources/file_manager/OWNERS (right): https://codereview.chromium.org/24024002/diff/3001/chrome/browser/resources/file_manager/OWNERS#newcode1 chrome/browser/resources/file_manager/OWNERS:1: # This should match chrome/browser/resources/file_manager/OWNERS On 2013/09/06 06:40:55, yoshiki ...

7 years, 3 months ago (2013-09-06 07:11:04 UTC) #3

satorux1

7 years, 3 months ago (2013-09-09 06:49:50 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 manually as r221987 (presubmit successful).

Expand Messages | Collapse Messages