Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Issue 2402373002: Revert of [wasm] Base address for data segments can also be the value of a global variable. (Closed)

Created:
4 years, 2 months ago by Michael Achenbach
Modified:
4 years, 2 months ago
Reviewers:
titzer, rossberg
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [wasm] Base address for data segments can also be the value of a global variable. (patchset #1 id:1 of https://codereview.chromium.org/2403823002/ ) Reason for revert: msan not happy: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20MSAN/builds/11332 Original issue's description: > [wasm] Base address for data segments can also be the value of a global variable. > > R=rossberg@chromium.org > BUG=chromium:575167 > > Committed: https://crrev.com/640ae3f9d20dcae915dbfa978bf48944cd4d0dc3 > Cr-Commit-Position: refs/heads/master@{#40121} TBR=rossberg@chromium.org,titzer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:575167 Committed: https://crrev.com/a6fb296a783aa0bbe076dec511d179a893a144b9 Cr-Commit-Position: refs/heads/master@{#40123}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -129 lines) Patch
M src/wasm/wasm-module.cc View 7 chunks +11 lines, -27 lines 0 comments Download
D test/mjsunit/wasm/data-segments.js View 1 chunk +0 lines, -90 lines 0 comments Download
M test/mjsunit/wasm/test-wasm-module-builder.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/wasm/wasm-module-builder.js View 2 chunks +4 lines, -11 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Michael Achenbach
Created Revert of [wasm] Base address for data segments can also be the value of ...
4 years, 2 months ago (2016-10-10 14:12:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2402373002/1
4 years, 2 months ago (2016-10-10 14:12:23 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-10 14:12:33 UTC) #5
commit-bot: I haz the power
4 years, 2 months ago (2016-10-10 14:12:57 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a6fb296a783aa0bbe076dec511d179a893a144b9
Cr-Commit-Position: refs/heads/master@{#40123}

Powered by Google App Engine
This is Rietveld 408576698