Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 24023006: Merge 157543 "Clear TemplateContentDocumentFragment::m_host when..." (Closed)

Created:
7 years, 3 months ago by kareng
Modified:
7 years, 3 months ago
Reviewers:
adamk
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, adamk+blink_chromium.org
Visibility:
Public.

Description

Merge 157543 "Clear TemplateContentDocumentFragment::m_host when..." > Clear TemplateContentDocumentFragment::m_host when HTMLTemplateElement is destroyed > > Note that the included test only crashes reliably in an asan build. > > R=inferno@chromium.org > BUG=286975 > > Review URL: https://chromiumcodereview.appspot.com/23708025 TBR=adamk@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157861

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
LayoutTests/fast/dom/HTMLTemplateElement/content-outlives-template-crash.html View 0 chunks +-1 lines, --1 lines 0 comments Download
LayoutTests/fast/dom/HTMLTemplateElement/content-outlives-template-crash-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
Source/core/dom/TemplateContentDocumentFragment.h View 1 chunk +1 line, -0 lines 0 comments Download
Source/core/html/HTMLTemplateElement.h View 2 chunks +4 lines, -2 lines 0 comments Download
Source/core/html/HTMLTemplateElement.cpp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
kareng
7 years, 3 months ago (2013-09-16 22:48:06 UTC) #1
kareng
Committed patchset #1 manually as r157861.
7 years, 3 months ago (2013-09-16 22:48:32 UTC) #2
adamk
7 years, 3 months ago (2013-09-17 18:54:53 UTC) #3
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698