include/v8.h - Issue 24023004: temporarily remove persistent destructor to allow trunk push

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: include/v8.h

Issue 24023004: temporarily remove persistent destructor to allow trunk push (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: include/v8.h

diff --git a/include/v8.h b/include/v8.h

index 004420c11d3670943574e159c4171eb5731e2c8a..11aa47394f55d63711b93708c6ff7252a8f651bf 100644

--- a/include/v8.h

+++ b/include/v8.h

@@ -549,9 +549,9 @@ template <class T, class M> class Persistent {

* kResetInDestructor flags in the traits class. Since not calling dispose

* can result in a memory leak, it is recommended to always set this flag.

- V8_INLINE(~Persistent()) {

- if (M::kResetInDestructor) Reset();

- }

+// V8_INLINE(~Persistent()) {

Dmitry Lomov (no reviews) 2013/09/09 11:38:49 Since it is a public API, please remove completely

+// if (M::kResetInDestructor) Reset();

+// }

/**

* If non-empty, destroy the underlying storage cell

« no previous file with comments | « no previous file | test/cctest/test-api.cc » ('j') | no next file with comments »