Issue 24023004: temporarily remove persistent destructor to allow trunk push

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 24023004: temporarily remove persistent destructor to allow trunk push (Closed)

Created:
7 years, 3 months ago by dcarney

Modified:
7 years, 3 months ago

Reviewers:
Dmitry Lomov (no reviews)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

temporarily remove persistent destructor to allow trunk push TBR=dslomov@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=16590

Patch Set 1 #

Total comments: 1

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
	M	include/v8.h	View		1 chunk	+3 lines, -3 lines	1 comment	Download
	M	test/cctest/test-api.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Dmitry Lomov (no reviews)

7 years, 3 months ago (2013-09-09 11:38:48 UTC) #2

Message was sent while issue was closed.

not lgtm! 
Let's not have commented out code in public API. 
Thanks for fixing in follow-up CL.

https://codereview.chromium.org/24023004/diff/1/include/v8.h
File include/v8.h (right):

https://codereview.chromium.org/24023004/diff/1/include/v8.h#newcode552
include/v8.h:552: //  V8_INLINE(~Persistent()) {
Since it is a public API, please remove completely instead of commenting out
(just for the push)

Expand Messages | Collapse Messages