Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(734)

Issue 2402293002: Add a Javascript wrapper for InterfaceRegistry. (Closed)

Created:
4 years, 2 months ago by Sam McNally
Modified:
4 years, 2 months ago
CC:
Aaron Boodman, abarth-chromium, blink-reviews, chrome-apps-syd-reviews_chromium.org, chromium-reviews, creis+watch_chromium.org, darin (slow to review), darin-cc_chromium.org, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a Javascript wrapper for InterfaceRegistry. This allows layout tests to inject mojo interface requests, simulating such requests from the browser. BUG=593607 Committed: https://crrev.com/9b9e5b4c759a9c040bb2c9d5d20abcf3a5eaefb4 Cr-Commit-Position: refs/heads/master@{#424720}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+192 lines, -1 line) Patch
M content/shell/BUILD.gn View 1 2 chunks +3 lines, -0 lines 0 comments Download
A content/shell/renderer/layout_test/interface_registry_js_wrapper.h View 1 2 1 chunk +71 lines, -0 lines 0 comments Download
A content/shell/renderer/layout_test/interface_registry_js_wrapper.cc View 1 1 chunk +71 lines, -0 lines 0 comments Download
M content/shell/renderer/layout_test/layout_test_content_renderer_client.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/shell/renderer/layout_test/layout_test_content_renderer_client.cc View 1 2 3 2 chunks +30 lines, -0 lines 0 comments Download
M services/shell/public/cpp/interface_registry.h View 1 1 chunk +10 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/resources/mojo-helpers.js View 1 2 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 31 (22 generated)
Sam McNally
+rockot for //services/shell and third_party/WebKit/LayoutTests/resources/mojo-helpers.js +jochen for //content/renderer
4 years, 2 months ago (2016-10-10 08:22:11 UTC) #4
jochen (gone - plz use gerrit)
in the past, John pushed for layout test code to not be in content (but ...
4 years, 2 months ago (2016-10-10 12:36:03 UTC) #8
jam
On 2016/10/10 12:36:03, jochen wrote: > in the past, John pushed for layout test code ...
4 years, 2 months ago (2016-10-10 15:42:44 UTC) #9
Sam McNally
On 2016/10/10 12:36:03, jochen wrote: > in the past, John pushed for layout test code ...
4 years, 2 months ago (2016-10-11 00:10:13 UTC) #14
Ken Rockot(use gerrit already)
lgtm
4 years, 2 months ago (2016-10-11 18:59:45 UTC) #25
jochen (gone - plz use gerrit)
lgtm
4 years, 2 months ago (2016-10-12 09:28:18 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2402293002/100001
4 years, 2 months ago (2016-10-12 09:33:19 UTC) #28
commit-bot: I haz the power
Committed patchset #4 (id:100001)
4 years, 2 months ago (2016-10-12 12:32:58 UTC) #29
commit-bot: I haz the power
4 years, 2 months ago (2016-10-12 12:34:20 UTC) #31
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/9b9e5b4c759a9c040bb2c9d5d20abcf3a5eaefb4
Cr-Commit-Position: refs/heads/master@{#424720}

Powered by Google App Engine
This is Rietveld 408576698