Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Side by Side Diff: third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.h

Issue 2402273002: DrawingBuffer: Clean up GL state restoration (Closed)
Patch Set: Incorporate review feedback Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef WebGL2RenderingContextBase_h 5 #ifndef WebGL2RenderingContextBase_h
6 #define WebGL2RenderingContextBase_h 6 #define WebGL2RenderingContextBase_h
7 7
8 #include "bindings/core/v8/ScriptPromise.h" 8 #include "bindings/core/v8/ScriptPromise.h"
9 #include "modules/webgl/WebGLExtension.h" 9 #include "modules/webgl/WebGLExtension.h"
10 #include "modules/webgl/WebGLRenderingContextBase.h" 10 #include "modules/webgl/WebGLRenderingContextBase.h"
(...skipping 725 matching lines...) Expand 10 before | Expand all | Expand 10 after
736 DECLARE_VIRTUAL_TRACE_WRAPPERS(); 736 DECLARE_VIRTUAL_TRACE_WRAPPERS();
737 737
738 protected: 738 protected:
739 friend class V8WebGL2RenderingContext; 739 friend class V8WebGL2RenderingContext;
740 740
741 WebGL2RenderingContextBase( 741 WebGL2RenderingContextBase(
742 HTMLCanvasElement*, 742 HTMLCanvasElement*,
743 std::unique_ptr<WebGraphicsContext3DProvider>, 743 std::unique_ptr<WebGraphicsContext3DProvider>,
744 const CanvasContextCreationAttributes& requestedAttributes); 744 const CanvasContextCreationAttributes& requestedAttributes);
745 745
746 // DrawingBuffer::Client implementation.
747 void DrawingBufferClientRestorePixelUnpackBufferBinding() override;
748
746 // Helper function to validate target and the attachment combination for 749 // Helper function to validate target and the attachment combination for
747 // getFramebufferAttachmentParameters. Generate GL error and return false if 750 // getFramebufferAttachmentParameters. Generate GL error and return false if
748 // parameters are illegal. 751 // parameters are illegal.
749 bool validateGetFramebufferAttachmentParameterFunc(const char* functionName, 752 bool validateGetFramebufferAttachmentParameterFunc(const char* functionName,
750 GLenum target, 753 GLenum target,
751 GLenum attachment); 754 GLenum attachment);
752 755
753 bool validateClearBuffer(const char* functionName, 756 bool validateClearBuffer(const char* functionName,
754 GLenum buffer, 757 GLenum buffer,
755 GLsizei length); 758 GLsizei length);
(...skipping 145 matching lines...) Expand 10 before | Expand all | Expand 10 after
901 context, 904 context,
902 context->is3d() && 905 context->is3d() &&
903 WebGLRenderingContextBase::getWebGLVersion(context) >= 2, 906 WebGLRenderingContextBase::getWebGLVersion(context) >= 2,
904 context.is3d() && 907 context.is3d() &&
905 WebGLRenderingContextBase::getWebGLVersion(&context) >= 908 WebGLRenderingContextBase::getWebGLVersion(&context) >=
906 2); 909 2);
907 910
908 } // namespace blink 911 } // namespace blink
909 912
910 #endif 913 #endif
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698