Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Unified Diff: content/child/blink_platform_impl.cc

Issue 2402263002: Media Controls a11y: add text/description/role to more controls components. (Closed)
Patch Set: review comments Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/child/blink_platform_impl.cc
diff --git a/content/child/blink_platform_impl.cc b/content/child/blink_platform_impl.cc
index b02630358357766d44b5b840c59dd888a1f5e8ce..c4519aab942892b84bf6ab318a96764062e518cf 100644
--- a/content/child/blink_platform_impl.cc
+++ b/content/child/blink_platform_impl.cc
@@ -142,10 +142,14 @@ static int ToMessageID(WebLocalizedString::Name name) {
return IDS_AX_MEDIA_SHOW_CLOSED_CAPTIONS_BUTTON;
case WebLocalizedString::AXMediaHideClosedCaptionsButton:
return IDS_AX_MEDIA_HIDE_CLOSED_CAPTIONS_BUTTON;
- case WebLocalizedString::AxMediaCastOffButton:
+ case WebLocalizedString::AXMediaCastOffButton:
return IDS_AX_MEDIA_CAST_OFF_BUTTON;
- case WebLocalizedString::AxMediaCastOnButton:
+ case WebLocalizedString::AXMediaCastOnButton:
return IDS_AX_MEDIA_CAST_ON_BUTTON;
+ case WebLocalizedString::AXMediaDownloadButton:
+ return IDS_AX_MEDIA_DOWNLOAD_BUTTON;
+ case WebLocalizedString::AXMediaOverflowButton:
+ return IDS_AX_MEDIA_OVERFLOW_BUTTON;
case WebLocalizedString::AXMediaAudioElementHelp:
return IDS_AX_MEDIA_AUDIO_ELEMENT_HELP;
case WebLocalizedString::AXMediaVideoElementHelp:
@@ -178,10 +182,12 @@ static int ToMessageID(WebLocalizedString::Name name) {
return IDS_AX_MEDIA_SHOW_CLOSED_CAPTIONS_BUTTON_HELP;
case WebLocalizedString::AXMediaHideClosedCaptionsButtonHelp:
return IDS_AX_MEDIA_HIDE_CLOSED_CAPTIONS_BUTTON_HELP;
- case WebLocalizedString::AxMediaCastOffButtonHelp:
+ case WebLocalizedString::AXMediaCastOffButtonHelp:
return IDS_AX_MEDIA_CAST_OFF_BUTTON_HELP;
- case WebLocalizedString::AxMediaCastOnButtonHelp:
+ case WebLocalizedString::AXMediaCastOnButtonHelp:
return IDS_AX_MEDIA_CAST_ON_BUTTON_HELP;
+ case WebLocalizedString::AXMediaOverflowButtonHelp:
+ return IDS_AX_MEDIA_OVERFLOW_BUTTON_HELP;
case WebLocalizedString::AXMillisecondFieldText:
return IDS_AX_MILLISECOND_FIELD_TEXT;
case WebLocalizedString::AXMinuteFieldText:
@@ -244,8 +250,6 @@ static int ToMessageID(WebLocalizedString::Name name) {
return IDS_FORM_OTHER_TIME_LABEL;
case WebLocalizedString::OtherWeekLabel:
return IDS_FORM_OTHER_WEEK_LABEL;
- case WebLocalizedString::AxMediaOverflowButton:
- return IDS_AX_MEDIA_OVERFLOW_BUTTON;
case WebLocalizedString::OverflowMenuCaptions:
return IDS_MEDIA_OVERFLOW_MENU_CLOSED_CAPTIONS;
case WebLocalizedString::OverflowMenuCast:
« no previous file with comments | « content/app/strings/content_strings.grd ('k') | third_party/WebKit/Source/modules/accessibility/AXMediaControls.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698