Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(555)

Issue 240223010: Merge 261737 "Fixing a lifetime issue for Speech Recognition Bubble" (Closed)

Created:
6 years, 8 months ago by aarya
Modified:
6 years, 8 months ago
Reviewers:
Tommy Widenflycht
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

Merge 261737 "Fixing a lifetime issue for Speech Recognition Bubble" > Fixing a lifetime issue for Speech Recognition Bubble > It seems that on a slow XP machine the view can be deleted before the > Impl. Fixed by a simple observer pattern. > > BUG=352851 > > Review URL: https://codereview.chromium.org/213153002 TBR=tommyw@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=264644

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -2 lines) Patch
M chrome/browser/ui/views/speech_recognition_bubble_views.cc View 5 chunks +14 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
aarya
6 years, 8 months ago (2014-04-17 21:32:35 UTC) #1
aarya
6 years, 8 months ago (2014-04-17 21:32:49 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r264644.

Powered by Google App Engine
This is Rietveld 408576698