Issue 2402203002: tracing: remove sampling state profiler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2402203002: tracing: remove sampling state profiler

Created:
4 years, 2 months ago by Primiano Tucci (use gerrit)

Modified:
4 years, 2 months ago

Reviewers:

CC:
v8-reviews_googlegroups.com, v8-merges_googlegroups.com

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

More Reviews

Description

tracing: remove sampling state profiler Follow-up to chromium's https://crrev.com/2406703002 As per discussion in [1] the tracing sampling state profiler is not used anymore. The coverage of the TRACE_EVENT_SCOPED_SAMPLING_STATE macros became poor over time and new alternatives came out (e.g., V8 sampling profiler). Note: this has nothing to do with the V8 sampling profiler. [1] https://groups.google.com/a/chromium.org/d/msg/tracing/E3K6qF1YMI8/wapmBei2AQAJ BUG=

Patch Set 1 #

Created: 4 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -7 lines)			Patch
	M	src/d8.cc	View		2 chunks	+0 lines, -5 lines	0 comments	Download
	M	test/cctest/libplatform/test-tracing.cc	View		1 chunk	+0 lines, -2 lines	0 comments	Download