Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1208)

Unified Diff: cc/output/compositor_frame_sink.cc

Issue 2402173002: cc: Get rid of PostSwapBuffersComplete. (Closed)
Patch Set: postswap: fix-blimp-unittest-post-swap-acks Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/output/compositor_frame_sink.h ('k') | cc/output/output_surface.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/output/compositor_frame_sink.cc
diff --git a/cc/output/compositor_frame_sink.cc b/cc/output/compositor_frame_sink.cc
index 53525bdd250317ad25a2a1278cf6ba6b91905a74..0958a6214adb95c6f3cef1852352902b6f556952 100644
--- a/cc/output/compositor_frame_sink.cc
+++ b/cc/output/compositor_frame_sink.cc
@@ -22,15 +22,13 @@ CompositorFrameSink::CompositorFrameSink(
scoped_refptr<ContextProvider> context_provider,
scoped_refptr<ContextProvider> worker_context_provider)
: context_provider_(std::move(context_provider)),
- worker_context_provider_(std::move(worker_context_provider)),
- weak_ptr_factory_(this) {
+ worker_context_provider_(std::move(worker_context_provider)) {
client_thread_checker_.DetachFromThread();
}
CompositorFrameSink::CompositorFrameSink(
scoped_refptr<VulkanContextProvider> vulkan_context_provider)
- : vulkan_context_provider_(vulkan_context_provider),
- weak_ptr_factory_(this) {
+ : vulkan_context_provider_(vulkan_context_provider) {
client_thread_checker_.DetachFromThread();
}
@@ -64,12 +62,6 @@ void CompositorFrameSink::DetachFromClient() {
DetachFromClientInternal();
}
-void CompositorFrameSink::PostSwapBuffersComplete() {
- base::ThreadTaskRunnerHandle::Get()->PostTask(
- FROM_HERE, base::Bind(&CompositorFrameSink::OnSwapBuffersComplete,
- weak_ptr_factory_.GetWeakPtr()));
-}
-
// We don't post tasks bound to the client directly since they might run
// after the CompositorFrameSink has been destroyed.
void CompositorFrameSink::OnSwapBuffersComplete() {
@@ -86,7 +78,6 @@ void CompositorFrameSink::DetachFromClientInternal() {
}
context_provider_ = nullptr;
client_ = nullptr;
- weak_ptr_factory_.InvalidateWeakPtrs();
}
void CompositorFrameSink::DidLoseCompositorFrameSink() {
« no previous file with comments | « cc/output/compositor_frame_sink.h ('k') | cc/output/output_surface.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698