Issue 240213009: Introduce a macro enabling 'SimpleClassVectorTraits'

Issue 240213009: Introduce a macro enabling 'SimpleClassVectorTraits' (Closed)

Created:
6 years, 8 months ago by Mikhail

Modified:
6 years, 8 months ago

Reviewers:
eseidel

CC:
blink-reviews, Mads Ager (chromium), zoltan1, dsinclair, bemjb+rendering_chromium.org, eae+blinkwatch, leviw+renderwatch, abarth-chromium, dglazkov+blink, adamk+blink_chromium.org, jchaffraix+rendering, Inactive, haraken, pdr., Mikhail, kouhei+heap_chromium.org, rune+blink

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Introduce a macro enabling 'SimpleClassVectorTraits' Introduce a 'WTF_ALLOW_MOVE_INIT_AND_COMPARE_WITH_MEM_FUNCTIONS' macro enabling 'SimpleClassVectorTraits' to improve code readability. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=172136

Patch Set 1 #

Total comments: 2

Patch Set 2 : Added the comment #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -24 lines)			Patch
M	Source/core/events/NodeEventContext.h	View		1 chunk	+1 line, -6 lines	0 comments	Download
M	Source/core/html/parser/HTMLConstructionSite.h	View		1 chunk	+1 line, -3 lines	0 comments	Download
M	Source/core/rendering/RenderGeometryMap.h	View		1 chunk	+1 line, -5 lines	0 comments	Download
M	Source/platform/heap/HeapTest.cpp	View		1 chunk	+3 lines, -8 lines	0 comments	Download
M	Source/wtf/VectorTraits.h	View	1	2 chunks	+9 lines, -0 lines	0 comments	Download
M	Source/wtf/text/AtomicString.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 10 (0 generated)

Expand Messages | Collapse Messages

eseidel

lgtm https://codereview.chromium.org/240213009/diff/1/Source/wtf/VectorTraits.h File Source/wtf/VectorTraits.h (right): https://codereview.chromium.org/240213009/diff/1/Source/wtf/VectorTraits.h#newcode94 Source/wtf/VectorTraits.h:94: #define WTF_ALLOW_MOVE_INIT_AND_COMPARE_WITH_MEM_FUNCTIONS(ClassName) \ I would add one of ...

6 years, 8 months ago (2014-04-18 20:17:31 UTC) #2

Mikhail

https://codereview.chromium.org/240213009/diff/1/Source/wtf/VectorTraits.h File Source/wtf/VectorTraits.h (right): https://codereview.chromium.org/240213009/diff/1/Source/wtf/VectorTraits.h#newcode94 Source/wtf/VectorTraits.h:94: #define WTF_ALLOW_MOVE_INIT_AND_COMPARE_WITH_MEM_FUNCTIONS(ClassName) \ On 2014/04/18 20:17:31, eseidel wrote: > ...

6 years, 8 months ago (2014-04-22 08:57:07 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mikhail.pozdnyakov@intel.com/240213009/20001

6 years, 8 months ago (2014-04-22 09:09:25 UTC) #5

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

6 years, 8 months ago (2014-04-22 10:19:11 UTC) #6

commit-bot: I haz the power

Try jobs failed on following builders: tryserver.blink on linux_blink_dbg

6 years, 8 months ago (2014-04-22 10:19:11 UTC) #7

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mikhail.pozdnyakov@intel.com/240213009/20001

6 years, 8 months ago (2014-04-22 13:05:23 UTC) #9

Message was sent while issue was closed.

Change committed as 172136

Expand Messages | Collapse Messages