Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(411)

Side by Side Diff: src/serialize.cc

Issue 240213002: Removed Isolate::EnterDefaultIsolate. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/isolate.cc ('k') | src/v8.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 854 matching lines...) Expand 10 before | Expand all | Expand 10 after
865 VisitPointer(root); 865 VisitPointer(root);
866 866
867 // There's no code deserialized here. If this assert fires 867 // There's no code deserialized here. If this assert fires
868 // then that's changed and logging should be added to notify 868 // then that's changed and logging should be added to notify
869 // the profiler et al of the new code. 869 // the profiler et al of the new code.
870 CHECK_EQ(start_address, code_space->top()); 870 CHECK_EQ(start_address, code_space->top());
871 } 871 }
872 872
873 873
874 Deserializer::~Deserializer() { 874 Deserializer::~Deserializer() {
875 ASSERT(source_->AtEOF()); 875 // TODO(svenpanne) Re-enable this assertion when v8 initialization is fixed.
876 // ASSERT(source_->AtEOF());
876 if (external_reference_decoder_) { 877 if (external_reference_decoder_) {
877 delete external_reference_decoder_; 878 delete external_reference_decoder_;
878 external_reference_decoder_ = NULL; 879 external_reference_decoder_ = NULL;
879 } 880 }
880 } 881 }
881 882
882 883
883 // This is called on the roots. It is the driver of the deserialization 884 // This is called on the roots. It is the driver of the deserialization
884 // process. It is also called on the body of each function. 885 // process. It is also called on the body of each function.
885 void Deserializer::VisitPointers(Object** start, Object** end) { 886 void Deserializer::VisitPointers(Object** start, Object** end) {
(...skipping 997 matching lines...) Expand 10 before | Expand all | Expand 10 after
1883 1884
1884 bool SnapshotByteSource::AtEOF() { 1885 bool SnapshotByteSource::AtEOF() {
1885 if (0u + length_ - position_ > 2 * sizeof(uint32_t)) return false; 1886 if (0u + length_ - position_ > 2 * sizeof(uint32_t)) return false;
1886 for (int x = position_; x < length_; x++) { 1887 for (int x = position_; x < length_; x++) {
1887 if (data_[x] != SerializerDeserializer::nop()) return false; 1888 if (data_[x] != SerializerDeserializer::nop()) return false;
1888 } 1889 }
1889 return true; 1890 return true;
1890 } 1891 }
1891 1892
1892 } } // namespace v8::internal 1893 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/isolate.cc ('k') | src/v8.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698