Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Side by Side Diff: pkg/dev_compiler/test/browser/language_tests.js

Issue 2402123002: Use expect instead of unittest for json_lib_test. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 define(['dart_sdk', 'async_helper', 'unittest', 'require'], 5 define(['dart_sdk', 'async_helper', 'unittest', 'require'],
6 function(dart_sdk, async_helper, unittest, require) { 6 function(dart_sdk, async_helper, unittest, require) {
7 'use strict'; 7 'use strict';
8 8
9 async_helper = async_helper.async_helper; 9 async_helper = async_helper.async_helper;
10 10
(...skipping 373 matching lines...) Expand 10 before | Expand all | Expand 10 after
384 'default_arguments_test': fail 384 'default_arguments_test': fail
385 }, 385 },
386 386
387 'lib/convert': { 387 'lib/convert': {
388 'encoding_test': skip_timeout, 388 'encoding_test': skip_timeout,
389 389
390 // TODO(jmesserly): this is in an inconsistent state between our old and 390 // TODO(jmesserly): this is in an inconsistent state between our old and
391 // newer SDKs. 391 // newer SDKs.
392 'html_escape_test': ['skip'], 392 'html_escape_test': ['skip'],
393 393
394 'json_lib_test': 'unittest',
395
396 'json_utf8_chunk_test': skip_timeout, 394 'json_utf8_chunk_test': skip_timeout,
397 'latin1_test': skip_timeout, 395 'latin1_test': skip_timeout,
398 396
399 'streamed_conversion_json_encode1_test': skip_timeout, 397 'streamed_conversion_json_encode1_test': skip_timeout,
400 'streamed_conversion_json_utf8_decode_test': skip_timeout, 398 'streamed_conversion_json_utf8_decode_test': skip_timeout,
401 'streamed_conversion_json_utf8_encode_test': skip_timeout, 399 'streamed_conversion_json_utf8_encode_test': skip_timeout,
402 'streamed_conversion_utf8_decode_test': skip_timeout, 400 'streamed_conversion_utf8_decode_test': skip_timeout,
403 'streamed_conversion_utf8_encode_test': skip_timeout, 401 'streamed_conversion_utf8_encode_test': skip_timeout,
404 'utf85_test': skip_timeout, 402 'utf85_test': skip_timeout,
405 }, 403 },
(...skipping 488 matching lines...) Expand 10 before | Expand all | Expand 10 after
894 892
895 for (let action of unittest_tests) { 893 for (let action of unittest_tests) {
896 try { 894 try {
897 action(); 895 action();
898 } catch (e) { 896 } catch (e) {
899 console.error("Caught error tying to setup test:", e); 897 console.error("Caught error tying to setup test:", e);
900 } 898 }
901 } 899 }
902 }); 900 });
903 }); 901 });
OLDNEW
« no previous file with comments | « pkg/dev_compiler/lib/src/compiler/code_generator.dart ('k') | pkg/dev_compiler/test/codegen/expect.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698