Issue 2402123002: Use expect instead of unittest for json_lib_test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2402123002: Use expect instead of unittest for json_lib_test. (Closed)

Created:
4 years, 2 months ago by Bob Nystrom

Modified:
4 years, 2 months ago

Reviewers:
vsm

CC:
dev-compiler+reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Use expect instead of unittest for json_lib_test. One step closer to removing the deprecated unittest. R=vsm@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/b30571884fc7c7b0daa6ab55065c97ee5addd030

Created: 4 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+282 lines, -179 lines)			Patch
M	pkg/dev_compiler/lib/src/compiler/code_generator.dart	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	pkg/dev_compiler/test/browser/language_tests.js	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	pkg/dev_compiler/test/codegen/expect.dart	View	14 chunks	+80 lines, -31 lines	0 comments	Download
M	pkg/dev_compiler/test/codegen/lib/convert/json_lib_test.dart	View	2 chunks	+167 lines, -144 lines	0 comments	Download
M	pkg/dev_compiler/test/codegen_expected/expect.js	View	2 chunks	+32 lines, -1 line	0 comments	Download

Total messages: 5 (2 generated)

Bob Nystrom

4 years, 2 months ago (2016-10-10 16:42:45 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
b30571884fc7c7b0daa6ab55065c97ee5addd030 (presubmit successful).