Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(758)

Issue 24021006: Changed the test case to get it inline with the intended behavior (Closed)

Created:
7 years, 3 months ago by spartha
Modified:
7 years, 3 months ago
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Changed the test case to get it inline with the intended behavior The expected results match because the Render Image will return a size with the alternate content. The test case had an additional "/" in the file path, which lead to a failed load, whereas the Author intention was to to load it (I guess!). BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157475

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M LayoutTests/http/tests/security/frame-loading-via-document-write.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
spartha
Found this when I was going through some regressions. I will submit a patch if ...
7 years, 3 months ago (2013-09-06 14:58:41 UTC) #1
eseidel
The change looks reaonsable. Do you need expectation updates? I don't see any changes to ...
7 years, 3 months ago (2013-09-06 16:04:51 UTC) #2
spartha
On 2013/09/06 16:04:51, eseidel wrote: > The change looks reaonsable. Do you need expectation updates? ...
7 years, 3 months ago (2013-09-06 20:49:31 UTC) #3
eseidel
lgtm
7 years, 3 months ago (2013-09-09 20:18:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sudarshan.p@samsung.com/24021006/1
7 years, 3 months ago (2013-09-09 20:18:10 UTC) #5
commit-bot: I haz the power
7 years, 3 months ago (2013-09-09 21:20:27 UTC) #6
Message was sent while issue was closed.
Change committed as 157475

Powered by Google App Engine
This is Rietveld 408576698