Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Unified Diff: tools/perf/benchmarks/media.py

Issue 2402083002: Disable media.android.tough_video_cases on Android Nexus5X Perf (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/benchmarks/media.py
diff --git a/tools/perf/benchmarks/media.py b/tools/perf/benchmarks/media.py
index df35c714831ef573d2185e361e6a6347e45e5bcd..1dc5e7d4ac030a126789c9e8aefd5e43173c012a 100644
--- a/tools/perf/benchmarks/media.py
+++ b/tools/perf/benchmarks/media.py
@@ -85,9 +85,16 @@ class MediaAndroid(perf_benchmark.PerfBenchmark):
options = {'story_label_filter_exclude': 'is_4k,is_50fps'}
@classmethod
- def ShouldDisable(cls, possible_browser): # crbug.com/448092
- """Disable test for Android One device."""
- return cls.IsSvelte(possible_browser)
+ def ShouldDisable(cls, possible_browser):
+ # crbug.com/448092
+ if cls.IsSvelte(possible_browser):
+ return True
+
+ # crbug.com/647372
+ if possible_browser.platform.GetDeviceTypeName() == 'Nexus 5X':
+ return True
+
+ return False
@classmethod
def Name(cls):
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698