Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 2402063002: Report 0 rowsDecoded for no rows (SkPngCodec interlaced) (Closed)

Created:
4 years, 2 months ago by scroggo_chromium
Modified:
4 years, 2 months ago
Reviewers:
msarett
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Report 0 rowsDecoded for no rows (SkPngCodec interlaced) incrementalDecode is supposed to report the number of rows decoded. It failed to if none were decoded (for an interlaced png). Fix the bug and add a test. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2402063002 Committed: https://skia.googlesource.com/skia/+/e61b3b4018a3e139e9ae19d2c47dc59deeaedd16

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -0 lines) Patch
M src/codec/SkPngCodec.cpp View 1 1 chunk +3 lines, -0 lines 0 comments Download
M tests/CodecTest.cpp View 1 chunk +29 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 9 (5 generated)
scroggo_chromium
4 years, 2 months ago (2016-10-07 20:58:01 UTC) #3
msarett
lgtm
4 years, 2 months ago (2016-10-10 00:33:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2402063002/20001
4 years, 2 months ago (2016-10-10 13:59:19 UTC) #7
commit-bot: I haz the power
4 years, 2 months ago (2016-10-10 14:17:35 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/e61b3b4018a3e139e9ae19d2c47dc59deeaedd16

Powered by Google App Engine
This is Rietveld 408576698