Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(503)

Issue 2402003003: Replace deprecated version of SetWithoutPathExpansion (Closed)

Created:
4 years, 2 months ago by dhna
Modified:
4 years, 2 months ago
Reviewers:
tapted
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace deprecated version of SetWithoutPathExpansion under src/apps BUG=650082 Committed: https://crrev.com/46702995890ed346d8c258c394c6a6093cfa1670 Cr-Commit-Position: refs/heads/master@{#424115}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M apps/saved_files_service.cc View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
dhna
tapted@ PTAL
4 years, 2 months ago (2016-10-08 08:56:35 UTC) #2
tapted
lgtm, just a nit on the CL description - it should at least be different ...
4 years, 2 months ago (2016-10-10 02:10:47 UTC) #3
dhna
On 2016/10/10 02:10:47, tapted wrote: > lgtm, just a nit on the CL description - ...
4 years, 2 months ago (2016-10-10 02:37:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2402003003/1
4 years, 2 months ago (2016-10-10 02:37:43 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-10 03:28:10 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-10-10 03:31:21 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/46702995890ed346d8c258c394c6a6093cfa1670
Cr-Commit-Position: refs/heads/master@{#424115}

Powered by Google App Engine
This is Rietveld 408576698