Teach Clang plugin about blink namespace

Teach Clang plugin about blink namespace

We're in the process of renaming the WebKit namespace to blink. The Clang
plugin has special logic for the WebKit namespace, so we need to teach it about
the new name.

R=thakis
BUG=295096
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=224255

[jamesr, 2013-09-19 21:32:29]

(unofficial) lgtm

[Nico, 2013-09-19 21:36:42]

lgtm

(Please be aware that the plugin is bundled with clang binaries and it usually
takes a while after this lands for this change to become active)

https://codereview.chromium.org/24020005/diff/1/tools/clang/plugins/ChromeCla...
File tools/clang/plugins/ChromeClassTester.cpp (right):

https://codereview.chromium.org/24020005/diff/1/tools/clang/plugins/ChromeCla...
tools/clang/plugins/ChromeClassTester.cpp:145: // We're in the process of
renaming WebKit to blink.
'TODO: Remove "WebKit" once that's done.'

[abarth-chromium, 2013-09-19 21:38:47]

On 2013/09/19 21:36:42, Nico wrote:
> lgtm
> 
> (Please be aware that the plugin is bundled with clang binaries and it usually
> takes a while after this lands for this change to become active)

Understood.  Is there a good way to know when it becomes active?

>
https://codereview.chromium.org/24020005/diff/1/tools/clang/plugins/ChromeCla...
> File tools/clang/plugins/ChromeClassTester.cpp (right):
> 
>
https://codereview.chromium.org/24020005/diff/1/tools/clang/plugins/ChromeCla...
> tools/clang/plugins/ChromeClassTester.cpp:145: // We're in the process of
> renaming WebKit to blink.
> 'TODO: Remove "WebKit" once that's done.'

Done.

Thanks for the review!

[commit-bot: I haz the power, 2013-09-19 21:41:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/abarth@chromium.org/24020005/8001

[(unused - use chromium), 2013-09-19 21:44:34]

On Thu, Sep 19, 2013 at 2:38 PM, <abarth@chromium.org> wrote:

> On 2013/09/19 21:36:42, Nico wrote:
>
>> lgtm
>>
>
>  (Please be aware that the plugin is bundled with clang binaries and it
>> usually
>> takes a while after this lands for this change to become active)
>>
>
> Understood.  Is there a good way to know when it becomes active?


Not really. I can try to remember to ping you :-/


>
>
>
> https://codereview.chromium.**org/24020005/diff/1/tools/**clang/plugins/**
>
ChromeClassTester.cpp<https://codereview.chromium.org/24020005/diff/1/tools/clang/plugins/ChromeClassTester.cpp>
>
>> File tools/clang/plugins/**ChromeClassTester.cpp (right):
>>
>
>
> https://codereview.chromium.**org/24020005/diff/1/tools/**clang/plugins/**
>
ChromeClassTester.cpp#**newcode145<https://codereview.chromium.org/24020005/diff/1/tools/clang/plugins/ChromeClassTester.cpp#newcode145>
>
>> tools/clang/plugins/**ChromeClassTester.cpp:145: // We're in the process
>> of
>> renaming WebKit to blink.
>> 'TODO: Remove "WebKit" once that's done.'
>>
>
> Done.
>
> Thanks for the review!
>
>
https://codereview.chromium.**org/24020005/<https://codereview.chromium.org/2...
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2013-09-20 00:28:07]

Change committed as 224255