Issue 2401973002: Fix command line argument passed to git diff in update-w3c-test-expectations.

Issue 2401973002: Fix command line argument passed to git diff in update-w3c-test-expectations. (Closed)

Created:
4 years, 2 months ago by qyearsley

Modified:
4 years, 2 months ago

Reviewers:
jsbell, jeffcarp

CC:
blink-reviews, blink-reviews-w3ctests_chromium.org, chromium-reviews, Dirk Pranke

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Fix command line argument passed to git diff in update-w3c-test-expectations. This is a follow-up fix for http://crrev.com/2389873002. BUG=649691 Committed: https://crrev.com/0d2ce5afae26790b0d859a9b40dce06d6811821c Cr-Commit-Position: refs/heads/master@{#423893}

Created: 4 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	third_party/WebKit/Tools/Scripts/webkitpy/w3c/update_w3c_test_expectations.py	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	third_party/WebKit/Tools/Scripts/webkitpy/w3c/update_w3c_test_expectations_unittest.py	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 12 (6 generated)

qyearsley

On 2016/10/07 at 16:34:44, jsbell wrote: > d'oh, sorry I missed that during the review. ...

4 years, 2 months ago (2016-10-07 16:41:11 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2401973002/20001

4 years, 2 months ago (2016-10-07 16:41:44 UTC) #9

commit-bot: I haz the power

4 years, 2 months ago (2016-10-07 17:17:49 UTC) #12

Message was sent while issue was closed.

Patchset 2 (id:??) landed as
https://crrev.com/0d2ce5afae26790b0d859a9b40dce06d6811821c
Cr-Commit-Position: refs/heads/master@{#423893}