Add a fuzzer target for MP4 AVCC record parsing

Add a fuzzer target for MP4 AVCC record parsing

Committed: https://crrev.com/44b5c4dd5ea3f4c91f24476696d3926c9a5c9094
Cr-Commit-Position: refs/heads/master@{#425779}

[watk, 2016-10-07 23:53:41]

The CQ bit was checked by watk@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-07 23:54:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[watk, 2016-10-07 23:54:28]

watk@chromium.org changed reviewers:
+ jrummell@chromium.org

[watk, 2016-10-07 23:54:28]

PTAL, also, do I have to do anything to make this run on a bot? Or does it get
automatically found?

[watk, 2016-10-08 00:02:08]

The CQ bit was checked by watk@chromium.org to run a CQ dry run

[watk, 2016-10-08 00:02:27]

Nvm, I found the docs :) Disabled the error logging.

[commit-bot: I haz the power, 2016-10-08 00:02:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[inferno, 2016-10-08 00:31:52]

inferno@chromium.org changed reviewers:
+ inferno@chromium.org

[inferno, 2016-10-08 00:31:52]

lgtm, this will be auto-archived and then auto-run by clusterfuzz.

[inferno, 2016-10-08 00:34:57]

lgtm, this will be auto-archived and then auto-run by clusterfuzz.

[kcc1, 2016-10-08 01:11:03]

On 2016/10/08 00:34:57, inferno wrote:
> lgtm, this will be auto-archived and then auto-run by clusterfuzz.

We also encourage to provide seed corpus to make the bot's live simpler. 
E.g. like this:
https://cs.chromium.org/chromium/src/testing/libfuzzer/fuzzers/woff2_corpus/?...

[commit-bot: I haz the power, 2016-10-08 01:23:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-08 01:23:19]

Dry run: Exceeded global retry quota

[jrummell, 2016-10-10 17:40:58]

lgtm

[watk, 2016-10-11 19:39:52]

Hmm, I didn't consider this. box_definitions.cc is only compiled in when
proprietary_codecs = true. Let me see if I can make it build regardless, or
whether it depends on too much other stuff.

[mmoroz, 2016-10-12 11:02:21]

On 2016/10/11 19:39:52, watk wrote:
> Hmm, I didn't consider this. box_definitions.cc is only compiled in when
> proprietary_codecs = true. Let me see if I can make it build regardless, or
> whether it depends on too much other stuff.

Should it be a problem? We use 'proprietary_codecs=true' for building fuzzers.
Reproducing instruction also advices to use it:
https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/rep...

[mmoroz, 2016-10-12 11:04:37]

On 2016/10/12 11:02:21, mmoroz wrote:
> On 2016/10/11 19:39:52, watk wrote:
> > Hmm, I didn't consider this. box_definitions.cc is only compiled in when
> > proprietary_codecs = true. Let me see if I can make it build regardless, or
> > whether it depends on too much other stuff.
> 
> Should it be a problem? We use 'proprietary_codecs=true' for building fuzzers.
> Reproducing instruction also advices to use it:
>
https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/rep...

Ah, I see, some trybots failed due to that. I think you can simply put
fuzzer_test inside if (proprietary_codecs) {} block. An example:
https://cs.chromium.org/chromium/src/media/BUILD.gn?type=cs&q=proprietary_cod...

[watk, 2016-10-17 18:59:23]

On 2016/10/12 11:04:37, mmoroz wrote:
> On 2016/10/12 11:02:21, mmoroz wrote:
> > On 2016/10/11 19:39:52, watk wrote:
> > > Hmm, I didn't consider this. box_definitions.cc is only compiled in when
> > > proprietary_codecs = true. Let me see if I can make it build regardless,
or
> > > whether it depends on too much other stuff.
> > 
> > Should it be a problem? We use 'proprietary_codecs=true' for building
fuzzers.
> > Reproducing instruction also advices to use it:
> >
>
https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/rep...
> 
> Ah, I see, some trybots failed due to that. I think you can simply put
> fuzzer_test inside if (proprietary_codecs) {} block. An example:
>
https://cs.chromium.org/chromium/src/media/BUILD.gn?type=cs&q=proprietary_cod...

Oh, I didn't realize the fuzzers used proprietary codecs, great.

Done.

[watk, 2016-10-17 18:59:35]

The CQ bit was checked by watk@chromium.org

[watk, 2016-10-17 18:59:35]

The patchset sent to the CQ was uploaded after l-g-t-m from
jrummell@chromium.org, inferno@chromium.org
Link to the patchset: https://codereview.chromium.org/2401963003/#ps40001
(title: "condition target on proprietary codecs")

[commit-bot: I haz the power, 2016-10-17 18:59:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-17 21:16:58]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-17 21:19:07]

Description was changed from

==========
Add a fuzzer target for MP4 AVCC record parsing
==========

to

==========
Add a fuzzer target for MP4 AVCC record parsing

Committed: https://crrev.com/44b5c4dd5ea3f4c91f24476696d3926c9a5c9094
Cr-Commit-Position: refs/heads/master@{#425779}
==========

[commit-bot: I haz the power, 2016-10-17 21:19:08]

Patchset 3 (id:??) landed as
https://crrev.com/44b5c4dd5ea3f4c91f24476696d3926c9a5c9094
Cr-Commit-Position: refs/heads/master@{#425779}