components/infobars/DEPS - Issue 240193003: Move Infobars core files to the Infobars component

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/infobars/DEPS

Issue 240193003: Move Infobars core files to the Infobars component (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix components/OWNERS Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 include_rules = [

	2 # Infobars is a component that is not allowed to uses content/ so that it

	3 # can be shared on iOS.
	Peter Kasting 2014/04/16 20:18:01 Nit: How about: The infobars component may not us Nit: How about: The infobars component may not use content/. This makes it possible to use on iOS. droger 2014/04/17 08:09:53 Actually my comment was wrong, as infobars will us Show quoted text On 2014/04/16 20:18:01, Peter Kasting wrote: > Nit: How about: > > The infobars component may not use content/. This makes it possible to use on > iOS. Actually my comment was wrong, as infobars will use content, but just not in infobars/core/: InfoBarService will go to components/infobars/content/ and will use content. I updated the text to use the same language as components/translate/DEPS and components/autofill/DEPS.
	4 "-content",

	5 "+ui",

	6 "+third_party/skia"

	7 ]

OLD	NEW