src/mips/assembler-mips.cc - Issue 240193002: Serializer enable/disable flags need thread safety.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/mips/assembler-mips.cc

Issue 240193002: Serializer enable/disable flags need thread safety. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Code comment response. Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/mips/assembler-mips.cc

diff --git a/src/mips/assembler-mips.cc b/src/mips/assembler-mips.cc

index cc45cda5f3c76ce817429329fc7c23d6fe76192a..29df222f40c78f76b72c9f6be79b1ad89adfa7c4 100644

--- a/src/mips/assembler-mips.cc

+++ b/src/mips/assembler-mips.cc

@@ -105,7 +105,8 @@ const char* DoubleRegister::AllocationIndexToString(int index) {

void CpuFeatures::Probe() {

unsigned standard_features = (OS::CpuFeaturesImpliedByPlatform() |

CpuFeaturesImpliedByCompiler());

- ASSERT(supported_ == 0 || supported_ == standard_features);

+ ASSERT(supported_ == 0 ||

+ (supported_ & standard_features) == standard_features);

#ifdef DEBUG

initialized_ = true;

#endif

« no previous file with comments | « src/ia32/assembler-ia32.cc ('k') | src/mksnapshot.cc » ('j') | no next file with comments »