src/x64/assembler-x64.cc - Issue 240193002: Serializer enable/disable flags need thread safety.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/assembler-x64.cc

Issue 240193002: Serializer enable/disable flags need thread safety. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Rebase Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/x64/assembler-x64.cc

diff --git a/src/x64/assembler-x64.cc b/src/x64/assembler-x64.cc

index 19bd82856e4da18fe547069179b6c7b8db94ff66..63688f62201c3dfaa39e131f478e5af792fe66c5 100644

--- a/src/x64/assembler-x64.cc

+++ b/src/x64/assembler-x64.cc

@@ -2954,9 +2954,7 @@ void Assembler::RecordRelocInfo(RelocInfo::Mode rmode, intptr_t data) {

if (rmode == RelocInfo::EXTERNAL_REFERENCE) {

// Don't record external references unless the heap will be serialized.

#ifdef DEBUG

- if (!Serializer::enabled()) {

- Serializer::TooLateToEnableNow();

- }

+ Serializer::TrySetPermanentlyDisabled();

#endif

if (!Serializer::enabled() && !emit_debug_code()) {

return;