Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: src/x64/assembler-x64.cc

Issue 240193002: Serializer enable/disable flags need thread safety. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Code comment response. Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/v8.cc ('k') | src/x64/macro-assembler-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 2935 matching lines...) Expand 10 before | Expand all | Expand 10 after
2946 emitl(data); 2946 emitl(data);
2947 } 2947 }
2948 2948
2949 2949
2950 // Relocation information implementations. 2950 // Relocation information implementations.
2951 2951
2952 void Assembler::RecordRelocInfo(RelocInfo::Mode rmode, intptr_t data) { 2952 void Assembler::RecordRelocInfo(RelocInfo::Mode rmode, intptr_t data) {
2953 ASSERT(!RelocInfo::IsNone(rmode)); 2953 ASSERT(!RelocInfo::IsNone(rmode));
2954 if (rmode == RelocInfo::EXTERNAL_REFERENCE) { 2954 if (rmode == RelocInfo::EXTERNAL_REFERENCE) {
2955 // Don't record external references unless the heap will be serialized. 2955 // Don't record external references unless the heap will be serialized.
2956 #ifdef DEBUG
2957 if (!Serializer::enabled()) {
2958 Serializer::TooLateToEnableNow();
2959 }
2960 #endif
2961 if (!Serializer::enabled() && !emit_debug_code()) { 2956 if (!Serializer::enabled() && !emit_debug_code()) {
2962 return; 2957 return;
2963 } 2958 }
2964 } else if (rmode == RelocInfo::CODE_AGE_SEQUENCE) { 2959 } else if (rmode == RelocInfo::CODE_AGE_SEQUENCE) {
2965 // Don't record psuedo relocation info for code age sequence mode. 2960 // Don't record psuedo relocation info for code age sequence mode.
2966 return; 2961 return;
2967 } 2962 }
2968 RelocInfo rinfo(pc_, rmode, data, NULL); 2963 RelocInfo rinfo(pc_, rmode, data, NULL);
2969 reloc_info_writer.Write(&rinfo); 2964 reloc_info_writer.Write(&rinfo);
2970 } 2965 }
(...skipping 50 matching lines...) Expand 10 before | Expand all | Expand 10 after
3021 3016
3022 3017
3023 bool RelocInfo::IsInConstantPool() { 3018 bool RelocInfo::IsInConstantPool() {
3024 return false; 3019 return false;
3025 } 3020 }
3026 3021
3027 3022
3028 } } // namespace v8::internal 3023 } } // namespace v8::internal
3029 3024
3030 #endif // V8_TARGET_ARCH_X64 3025 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/v8.cc ('k') | src/x64/macro-assembler-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698