Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Side by Side Diff: src/ia32/assembler-ia32.cc

Issue 240193002: Serializer enable/disable flags need thread safety. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Code comment response. Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/flags.cc ('k') | src/mips/assembler-mips.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 1994-2006 Sun Microsystems Inc. 1 // Copyright (c) 1994-2006 Sun Microsystems Inc.
2 // All Rights Reserved. 2 // All Rights Reserved.
3 // 3 //
4 // Redistribution and use in source and binary forms, with or without 4 // Redistribution and use in source and binary forms, with or without
5 // modification, are permitted provided that the following conditions 5 // modification, are permitted provided that the following conditions
6 // are met: 6 // are met:
7 // 7 //
8 // - Redistributions of source code must retain the above copyright notice, 8 // - Redistributions of source code must retain the above copyright notice,
9 // this list of conditions and the following disclaimer. 9 // this list of conditions and the following disclaimer.
10 // 10 //
(...skipping 2685 matching lines...) Expand 10 before | Expand all | Expand 10 after
2696 void Assembler::dd(uint32_t data) { 2696 void Assembler::dd(uint32_t data) {
2697 EnsureSpace ensure_space(this); 2697 EnsureSpace ensure_space(this);
2698 emit(data); 2698 emit(data);
2699 } 2699 }
2700 2700
2701 2701
2702 void Assembler::RecordRelocInfo(RelocInfo::Mode rmode, intptr_t data) { 2702 void Assembler::RecordRelocInfo(RelocInfo::Mode rmode, intptr_t data) {
2703 ASSERT(!RelocInfo::IsNone(rmode)); 2703 ASSERT(!RelocInfo::IsNone(rmode));
2704 // Don't record external references unless the heap will be serialized. 2704 // Don't record external references unless the heap will be serialized.
2705 if (rmode == RelocInfo::EXTERNAL_REFERENCE) { 2705 if (rmode == RelocInfo::EXTERNAL_REFERENCE) {
2706 #ifdef DEBUG
2707 if (!Serializer::enabled()) {
2708 Serializer::TooLateToEnableNow();
2709 }
2710 #endif
2711 if (!Serializer::enabled() && !emit_debug_code()) { 2706 if (!Serializer::enabled() && !emit_debug_code()) {
2712 return; 2707 return;
2713 } 2708 }
2714 } 2709 }
2715 RelocInfo rinfo(pc_, rmode, data, NULL); 2710 RelocInfo rinfo(pc_, rmode, data, NULL);
2716 reloc_info_writer.Write(&rinfo); 2711 reloc_info_writer.Write(&rinfo);
2717 } 2712 }
2718 2713
2719 2714
2720 Handle<ConstantPoolArray> Assembler::NewConstantPool(Isolate* isolate) { 2715 Handle<ConstantPoolArray> Assembler::NewConstantPool(Isolate* isolate) {
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
2752 fprintf(coverage_log, "%s\n", file_line); 2747 fprintf(coverage_log, "%s\n", file_line);
2753 fflush(coverage_log); 2748 fflush(coverage_log);
2754 } 2749 }
2755 } 2750 }
2756 2751
2757 #endif 2752 #endif
2758 2753
2759 } } // namespace v8::internal 2754 } } // namespace v8::internal
2760 2755
2761 #endif // V8_TARGET_ARCH_IA32 2756 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/flags.cc ('k') | src/mips/assembler-mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698