third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp - Issue 2401903002: Compute and include the offset of the sticky box to its enclosing composited layer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp

Issue 2401903002: Compute and include the offset of the sticky box to its enclosing composited layer. (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« cc/trees/layer_tree_host_common_unittest.cc ('K') | « cc/trees/property_tree_builder.cc ('k') | third_party/WebKit/Source/web/tests/ScrollingCoordinatorTest.cpp » ('j') | third_party/WebKit/Source/web/tests/ScrollingCoordinatorTest.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp

diff --git a/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp b/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp

index f9e9c1e7acdc96ee82cd141590d4d6d39b267ada..ccef006b1f6c036b15470d427d2a0ec196111ebe 100644

--- a/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp

+++ b/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp

@@ -302,6 +302,16 @@ void CompositedLayerMapping::updateStickyConstraints(

const StickyPositionScrollingConstraints& constraints =

ancestorOverflowLayer->getScrollableArea()->stickyConstraintsMap().get(

&m_owningLayer);

+ // Find the layout offset of the unshifted sticky box within its enclosing layer.

+ LayoutPoint enclosingLayerOffset;

+ m_owningLayer.enclosingLayerWithCompositedLayerMapping(ExcludeSelf)

+ ->convertToLayerCoords(m_owningLayer.ancestorOverflowLayer(),

+ enclosingLayerOffset);

+ FloatPoint stickyBoxOffset =

+ constraints.scrollContainerRelativeStickyBoxRect().location();

+ stickyBoxOffset.moveBy(FloatPoint(-enclosingLayerOffset));

webConstraint.isSticky = true;

webConstraint.isAnchoredLeft =

constraints.anchorEdges() &

@@ -319,6 +329,8 @@ void CompositedLayerMapping::updateStickyConstraints(

webConstraint.rightOffset = constraints.rightOffset();

webConstraint.topOffset = constraints.topOffset();

webConstraint.bottomOffset = constraints.bottomOffset();

+ webConstraint.parentRelativeStickyBoxOffset =

+ roundedIntPoint(stickyBoxOffset);

webConstraint.scrollContainerRelativeStickyBoxRect =

enclosingIntRect(constraints.scrollContainerRelativeStickyBoxRect());

webConstraint.scrollContainerRelativeContainingBlockRect = enclosingIntRect(