Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 24019008: cc: Remove safe_to_expect_begin_frame workaround (Closed)

Created:
7 years, 3 months ago by brianderson
Modified:
7 years, 3 months ago
Reviewers:
nduca, reveman
CC:
chromium-reviews, cc-bugs_chromium.org, Sami (do not use), enne (OOO), danakj, jdduke (slow), boliu, joth
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

cc: Remove safe_to_expect_begin_frame workaround The safe_to_expect_begin_frame workaround should no longer be needed because the scheduler properly only requests a BeginFrame when there is an output surface now. Removing the workaround will also help avoid race conditions where we receive overlapping BeginFrames with the deadline scheduler. BUG=289627 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222729

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -11 lines) Patch
M cc/scheduler/scheduler.h View 1 chunk +0 lines, -3 lines 0 comments Download
M cc/scheduler/scheduler.cc View 5 chunks +1 line, -8 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
brianderson
7 years, 3 months ago (2013-09-11 18:32:26 UTC) #1
brianderson
Adding @reveman as a reviewer since this removes a workaround for a bug that we ...
7 years, 3 months ago (2013-09-11 19:06:51 UTC) #2
nduca
lgtm if it helps
7 years, 3 months ago (2013-09-11 22:50:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/brianderson@chromium.org/24019008/1
7 years, 3 months ago (2013-09-11 22:54:11 UTC) #4
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
7 years, 3 months ago (2013-09-12 02:01:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/brianderson@chromium.org/24019008/1
7 years, 3 months ago (2013-09-12 02:11:08 UTC) #6
commit-bot: I haz the power
7 years, 3 months ago (2013-09-12 06:10:46 UTC) #7
Message was sent while issue was closed.
Change committed as 222729

Powered by Google App Engine
This is Rietveld 408576698