Chromium Code Reviews
DescriptionRevert of Open MessagePumpLibevent's pipe with O_CLOEXEC (patchset #4 id:60001 of https://codereview.chromium.org/2394413002/ )
Reason for revert:
Reverting since it breaks NaCL tests.
https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29%2832%29/builds/34211
failures:
NaClBrowserTestNonSfiMode.Irt
NaClBrowserTestNonSfiMode.Messaging
Original issue's description:
> Open MessagePumpLibevent's pipe with O_CLOEXEC
>
> This prevents the pipe's fds from being leaked into child processes.
>
> TEST=git cl try
> BUG=653930
>
> Committed: https://crrev.com/f9c8562e55b669915faf87d8d7eda32ae62bf661
> Cr-Commit-Position: refs/heads/master@{#423899}
TBR=dcheng@chromium.org,lhchavez@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=653930
Committed: https://crrev.com/c231da96b4586157979d9e2ec41561b7b115b2e2
Cr-Commit-Position: refs/heads/master@{#423966}
Patch Set 1 #
Messages
Total messages: 7 (3 generated)
|
|||||||||||||||||||||||||||||||||||||