Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 2401863004: Revert of Open MessagePumpLibevent's pipe with O_CLOEXEC (Closed)

Created:
4 years, 2 months ago by nasko
Modified:
4 years, 2 months ago
CC:
chromium-reviews, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Open MessagePumpLibevent's pipe with O_CLOEXEC (patchset #4 id:60001 of https://codereview.chromium.org/2394413002/ ) Reason for revert: Reverting since it breaks NaCL tests. https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29%2832%29/builds/34211 failures: NaClBrowserTestNonSfiMode.Irt NaClBrowserTestNonSfiMode.Messaging Original issue's description: > Open MessagePumpLibevent's pipe with O_CLOEXEC > > This prevents the pipe's fds from being leaked into child processes. > > TEST=git cl try > BUG=653930 > > Committed: https://crrev.com/f9c8562e55b669915faf87d8d7eda32ae62bf661 > Cr-Commit-Position: refs/heads/master@{#423899} TBR=dcheng@chromium.org,lhchavez@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=653930 Committed: https://crrev.com/c231da96b4586157979d9e2ec41561b7b115b2e2 Cr-Commit-Position: refs/heads/master@{#423966}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -47 lines) Patch
M base/files/file_util.h View 1 chunk +0 lines, -11 lines 0 comments Download
M base/files/file_util_posix.cc View 2 chunks +0 lines, -34 lines 0 comments Download
M base/message_loop/message_pump_libevent.cc View 1 chunk +10 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
nasko
Created Revert of Open MessagePumpLibevent's pipe with O_CLOEXEC
4 years, 2 months ago (2016-10-07 21:16:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2401863004/1
4 years, 2 months ago (2016-10-07 21:17:10 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-07 21:18:05 UTC) #5
commit-bot: I haz the power
4 years, 2 months ago (2016-10-07 21:19:29 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c231da96b4586157979d9e2ec41561b7b115b2e2
Cr-Commit-Position: refs/heads/master@{#423966}

Powered by Google App Engine
This is Rietveld 408576698