Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 24018009: Add -optimize-for-size flag to optimize for memory size (Closed)

Created:
7 years, 3 months ago by rmcilroy
Modified:
7 years, 2 months ago
CC:
v8-dev
Visibility:
Public.

Description

Add -optimize-for-size flag to optimize for memory size (will be used by pre-aging CL), and remove the is_memory_constrained ResourceConstraint. BUG=292928 R=hpayer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16960

Patch Set 1 #

Total comments: 4

Patch Set 2 : change to optimize-for-size #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -32 lines) Patch
M include/v8.h View 1 1 chunk +0 lines, -8 lines 0 comments Download
M src/api.cc View 2 chunks +1 line, -7 lines 0 comments Download
M src/flag-definitions.h View 1 2 chunks +5 lines, -3 lines 0 comments Download
M src/isolate.h View 2 chunks +0 lines, -8 lines 0 comments Download
M src/isolate.cc View 2 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
rmcilroy
7 years, 3 months ago (2013-09-23 10:15:11 UTC) #1
Hannes Payer (out of office)
https://codereview.chromium.org/24018009/diff/1/include/v8.h File include/v8.h (left): https://codereview.chromium.org/24018009/diff/1/include/v8.h#oldcode3755 include/v8.h:3755: Let's keep the last newline https://codereview.chromium.org/24018009/diff/1/src/flag-definitions.h File src/flag-definitions.h (right): ...
7 years, 3 months ago (2013-09-23 11:38:43 UTC) #2
rmcilroy
https://codereview.chromium.org/24018009/diff/1/include/v8.h File include/v8.h (left): https://codereview.chromium.org/24018009/diff/1/include/v8.h#oldcode3755 include/v8.h:3755: On 2013/09/23 11:38:43, Hannes Payer wrote: > Let's keep ...
7 years, 3 months ago (2013-09-23 12:40:15 UTC) #3
Hannes Payer (out of office)
LGTM, please change the title and the description of the cl
7 years, 3 months ago (2013-09-23 12:45:04 UTC) #4
rmcilroy
On 2013/09/23 12:45:04, Hannes Payer wrote: > LGTM, please change the title and the description ...
7 years, 3 months ago (2013-09-23 12:46:04 UTC) #5
rmcilroy
On 2013/09/23 12:46:04, rmcilroy wrote: > On 2013/09/23 12:45:04, Hannes Payer wrote: > > LGTM, ...
7 years, 3 months ago (2013-09-23 12:47:27 UTC) #6
Hannes Payer (out of office)
7 years, 2 months ago (2013-09-26 09:40:24 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 manually as r16960 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698