Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Issue 24018005: remove CcTest::default_isolate (Closed)

Created:
7 years, 3 months ago by dcarney
Modified:
7 years, 3 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -56 lines) Patch
M test/cctest/cctest.h View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/cctest.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-api.cc View 20 chunks +34 lines, -34 lines 0 comments Download
M test/cctest/test-debug.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M test/cctest/test-lockers.cc View 4 chunks +14 lines, -14 lines 0 comments Download
M test/cctest/test-threads.cc View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
dcarney
7 years, 3 months ago (2013-09-19 09:53:45 UTC) #1
Sven Panne
lgtm
7 years, 3 months ago (2013-09-19 09:55:08 UTC) #2
dcarney
7 years, 3 months ago (2013-09-19 09:56:20 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r16821 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698